Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#fn represent selected cols when the col-name is enclosed in quotation marks #2223

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

kaypark-skt
Copy link
Contributor

Description

While auto-typing is working,
The JsonRuleString of Set-Type rule can have column name is enclosed in "`"

Related Issue : None

How Has This Been Tested?

  1. create a dataset of number type fields -> auto-typing is working
  2. create a dataflow and make a wrangled dataset
  3. click edit button of the set-type rule in rule tab.
  4. make sure the column names of the select box is checked

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@kyungtaak
Copy link
Contributor

run build
deploy to 3

@kyungtaak kyungtaak added testbed3 Review Test Server 3 to master labels Jun 12, 2019
@kaypark-skt kaypark-skt merged commit 42f4e5c into 3.2.x Jun 12, 2019
alchan-lee pushed a commit that referenced this pull request Jun 14, 2019
@alchan-lee alchan-lee deleted the fn-fix-represent_selected_settype_cols branch June 17, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dataprep Component Name : Data preparation testbed3 Review Test Server 3 to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants