Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2131 metadata user view #2289

Merged
merged 22 commits into from
Jul 1, 2019
Merged

#2131 metadata user view #2289

merged 22 commits into from
Jul 1, 2019

Conversation

brandon-wonjune
Copy link
Contributor

Description

메타데이터 사용자 화면을 추가합니다.
lnb: catlaog 목록, catalog search
사용자화면 메인 화면
카탈로그 상세조회시 메타데이터 목록 화면

Related Issue :

#2131

How Has This Been Tested?

  1. lnb > explore data 화면 클릭
  2. 화면 진입시 사용자 메인화면에 메타데이터 인기도순, 수정, 즐겨찾기 순으로 정렬된 메타데이터 목록이 보이는지 확인
  3. lnb에서 카탈로그 목록이 제대로 보이는지 확인
  4. lnb에서 카탈로그 검색시 키워드 검색이 제대로 되는지 확인(키워드의 색깔이 변경되는지 확인)
  5. lnb에서 카탈로그 클릭시 해당 카탈로그 상세화면으로 보여지는지 확인

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

Gyojun.Goo and others added 20 commits June 3, 2019 14:33
#2131 add metadata user view menu in lnb
ed70e35
@paigechoi
#2131 Explore > metadata detail popup
643d465
@paigechoi
#2131 Explore > metadata detail popup > columns > add code table deta…
3869f79 
…il popup
@brandon-wonjune
#2131 init banner, card component
748fc49
@paigechoi
Merge remote-tracking branch 'origin/f#2131-metadata_user_view' into …
627678c 
…f#2131-metadata_user_view
@paigechoi
#2131 Fix lnb css
9f7cf65
@brandon-wonjune
#2131 init explore data main component
0383397
@brandon-wonjune
#2131 remove card wrap component
0009f2b
@brandon-wonjune
#2131 init catalog main component
672e782
@ufoscw
#2131 add api (count by sourceType)
f5d7b29
@brandon-wonjune
#2131 add catalog tree in explore data
94e57ca
@brandon-wonjune
#2131 change metadata list in explore catalog data
b58e95b
@ufoscw
#2131 add Catalog Projection(forSimpleTreeView)
45414f5
@brandon-wonjune
#2131 add catalog search in catalog tree
2214856
@brandon-wonjune
#2131 fix metadata card height
fdb4c75
@ufoscw
#2131 add api (order by popularity)
fbdad91
@brandon-wonjune
#2131 add popular metadata list
2cb6f28
@brandon-wonjune
#2131 add updated metadata list in explore data
18ef097
@brandon-wonjune
#2131 fix favorite metadata list length
df2d795
@brandon-wonjune
#2131 change explore data title ko lang
d51a504
@brandon-wonjune brandon-wonjune added the @metadata Component Name : Metadata label Jul 1, 2019
@ufoscw ufoscw added the testbed3 Review Test Server 3 label Jul 1, 2019
@ufoscw
Copy link
Contributor

ufoscw commented Jul 1, 2019

run build
deploy to 3

ufoscw
ufoscw previously approved these changes Jul 1, 2019
View reviewed changes
@ufoscw ufoscw requested a review from minhyun2 July 1, 2019 04:13
kyungtaak
kyungtaak previously approved these changes Jul 1, 2019
View reviewed changes
@ufoscw ufoscw dismissed stale reviews from kyungtaak and themself via d3b9eca July 1, 2019 04:29
@ufoscw ufoscw requested review from ufoscw and kyungtaak July 1, 2019 04:30
@ufoscw ufoscw merged commit be758e2 into master Jul 1, 2019
@alchan-lee alchan-lee deleted the f#2131-metadata_user_view branch August 2, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufoscw ufoscw ufoscw approved these changes

@kyungtaak kyungtaak kyungtaak approved these changes

@eltriny eltriny Awaiting requested review from eltriny

@AnnieHwang AnnieHwang Awaiting requested review from AnnieHwang

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

@minhyun2 minhyun2 Awaiting requested review from minhyun2

Assignees
No one assigned
Labels
@metadata Component Name : Metadata testbed3 Review Test Server 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandon-wonjune @ufoscw @kyungtaak @paigechoi