Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 3.3.x ui error #2946

Merged
merged 2 commits into from
Dec 9, 2019
Merged

fix 3.3.x ui error #2946

merged 2 commits into from
Dec 9, 2019

Conversation

eltriny
Copy link
Contributor

@eltriny eltriny commented Dec 6, 2019

Description

  1. The operation row display function does not work in the table view.
  2. You need to adjust the width of the data source list column.
  3. Administrator> Workspace> Details> Data Source Popup> Top part of the icon is cut off.
  4. Administrator> Workspace Permission> Workspace Permission Details> Workspace Details-Previous icon should be moved to Workspace list.
  5. Toast error exclusions are required when retrieving period dates in Users> Membership Approval.

Related Issue :

How Has This Been Tested?

  1. In the table view, check that the operation row is displayed normally.
  2. Verify that the data source list column width is adjusted.
  3. Verify that Administrator> Workspace> Details> Data Sources Popup> Top of the icon is displayed correctly.
  4. If Administrator> Workspace Permission> Workspace Permission Details> Workspace Details-Previous icon is clicked, check if it moves to Workspace list.
  5. Under Users> Membership Approval, verify that no warnings are displayed when searching for period dates.

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@eltriny eltriny requested review from kyungtaak, minhyun2, ufoscw and a team December 6, 2019 06:28
@minhyun2 minhyun2 added the testbed3 Review Test Server 3 label Dec 6, 2019
@minhyun2
Copy link
Contributor

minhyun2 commented Dec 6, 2019

deploy to 3

@kyungtaak kyungtaak merged commit aa6626b into 3.3.x Dec 9, 2019
@alchan-lee alchan-lee deleted the fn-fix_3.3.x_ui_error branch December 10, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testbed3 Review Test Server 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants