New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`meteor run` can leak processes without `webapp` module #3315

Closed
glasser opened this Issue Dec 18, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@glasser
Member

glasser commented Dec 18, 2014

We switched from keepalive to "app polls a parent pid" but this doesn't work if the app lacks webapp. We should move this check to boot.js (and maybe make it configured via env var instead of command-line option). eg, right now the autoupdate self-test leaks a process.

glasser added a commit that referenced this issue Jan 3, 2015

Refactor parent pid check; drop --keepalive
This commit moves parent pid process from the webapp package to the boot
script. This means that daemonized apps without webapp will also exit
when the runner exits, if run from the runner. (For example, several
self-tests such as 'autoupdate' no longer leak node processes.) This is
controlled via the $METEOR_PARENT_PID environment variable instead of
from command line arguments, in order to make fewer assumptions about
how Meteor apps process arguments.

This also drops the old --keepalive support (which already has stopped
being used by the dev mode runner or any MDG deployment platforms).
Neither --parent-pid nor --keepalive were documented beforehand, and
--keepalive was already deprecated before 1.0.

These flags used to also incidentally trigger printing the LISTENING
line; this is now controlled by $METEOR_PRINT_ON_LISTEN.

Fixes #3315.

@glasser glasser closed this in 096df9d Jan 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment