Switch typescript skeleton to zodern:types and test that it works #12510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As type definitions are moved to be shipped directly with the core Meteor packages, the @types/meteor NPM package is trending towards deprecation, so we should steer people to use the preferred way of pulling in type definitions. Additionally, add a test to make sure we're not steering them too far astray.
ebroder
added a commit
to ebroder/meteor-types
that referenced
this pull request
Feb 11, 2023
Since we're already reaching into the Meteor ProjectContext to get the package catalog, we can also grab the root that Meteor is using as its package store while we're in the area. This should fix using this package with a Meteor checkout, instead of a released version of Meteor, as when running from a checkout, Meteor creates a `.meteor` directory in the source tree, rather than using the `.meteor` directory in `$HOME` or `$LOCALAPPDATA`. This should additionally fix the integration test added in meteor/meteor#12510.
ebroder
added a commit
to ebroder/meteor-types
that referenced
this pull request
Feb 13, 2023
When running with a Meteor checkout, instead of a released version of Meteor, Meteor creates a `.meteor` directory in its own source tree, rather than using the `.meteor` directory in `$HOME` or `$LOCALDATA`. This means that when we use `zodern:types` in (e.g.) a self-test, such as the one added in meteor/meteor#12510, packages would not end up where we expected them. Unfortunately, when the package is published, it gets loaded after Meteor has already parsed the project context. So instead of reaching into Meteor's ProjectContext to get the package catalog, we instead create our own temporary context, following the example of what Meteor does for `meteor show`. Once we've done that, we can grab both the package catalog and the root of the package store.
ebroder
added a commit
to ebroder/meteor-types
that referenced
this pull request
Feb 23, 2023
Since we're already reaching into the Meteor ProjectContext to get the package catalog, we can also grab the root that Meteor is using as its package store while we're in the area. This should fix using this package with a Meteor checkout, instead of a released version of Meteor, as when running from a checkout, Meteor creates a `.meteor` directory in the source tree, rather than using the `.meteor` directory in `$HOME` or `$LOCALAPPDATA`. This should additionally fix the integration test added in meteor/meteor#12510.
ebroder
added a commit
to ebroder/meteor-types
that referenced
this pull request
Feb 23, 2023
Since we're already reaching into the Meteor ProjectContext to get the package catalog, we can also grab the root that Meteor is using as its package store while we're in the area. This should fix using this package with a Meteor checkout, instead of a released version of Meteor, as when running from a checkout, Meteor creates a `.meteor` directory in the source tree, rather than using the `.meteor` directory in `$HOME` or `$LOCALAPPDATA`. This should additionally fix the integration test added in meteor/meteor#12510.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As type definitions are moved to be shipped directly with the core Meteor packages, the @types/meteor NPM package is trending towards deprecation, so we should steer people to use the preferred way of pulling in type definitions.
Additionally, add a test to make sure we're not steering them too far astray.