Cordova 7.1.0, Android 6.3.0 and iOS 4.5.3 updates #9213
Conversation
|
Thanks for submitting this! Since your FR (meteor/meteor-feature-requests#196) mentioned getting it into Meteor 1.6, I'll just point out: Meteor 1.6 is already in release candidate status and meteor/meteor-feature-requests#196 isn't a bug so unless this fixes critical bugs present in Meteor 1.6 RCs, this will likely surface in other versions (e.g. 1.6.1 and 1.5.3). |
|
No worries, your call on Meteor 1.6.1. The Cordova Android 6.3.0 update does fix some issues that I've seen, but did not report as Meteor problems. Specifically |
|
Also, if this does not make it into Meteor 1.6 then we should break out the second comment I made in the History.md file as this change is in 1.6. |
|
One more potential thing is that we are already shipping |
|
@abernix Spoke with rest of my team on this and we'd like to request getting this in 1.6 if possible. Reason is this PR is pretty much the same as #9137 in scope, which updates |
|
Perfectly fair request! Though, I think I'm going to stick to my thinking of 1.6.1 and 1.5.3. The fix in #9137 was pulled in (late in the 1.6 process already) primarily because of #9098, which created a problem where the simulator just could not be launched, even without any updates to an existing project and on already-supported devices, due to hyphens in iOS device names being removed/changed in XCode's Device List ( We're getting very close on 1.6 and if we put this in now, there's a chance it won't have time to fully vet and the Has Cordova been working okay for you otherwise with Meteor 1.6? |
|
On another, semi-related note, thank you very much for your diligence on helping us stay on top of Cordova items! You've stood out countless times now, in that you're willing to look into and stay on top of the changes in Cordova, and even more valuably, step up and fix them quickly when you (and others) encounter them. It's truly appreciated! |
This change is now in #9227
hwillson
changed the title
skirunman
changed the title
Update to new Cordova iOS 4.5.2 release. https://cordova.apache.org/announcements/2017/10/16/ios-release.html
|
I updated this PR to include the Cordova iOS 4.5.2 release Also, there was a small merge conflict in the History.md file that might need to be sorted out on merge. |
skirunman
changed the title
Updating iOS launch screens to match what is supported in Cordova iOS 4.5.3 and remove latest iPad Pro sizes that are not supported in Xcode 9 and therefore not in Cordova iOS. See https://github.com/surajpindoria/cordova-ios/blob/c3d24a9f02aa096c2b8951cc6980eefbbd26fd72/bin/templates/scripts/cordova/lib/prepare.js
|
Hi, I am getting the original error when trying to |
While 'cordova-lib' used to live in 'dev-bundle-tool-package.js' where it was pre-bundled into the "dev bundle", that is no longer the case. It is now automatically installed, on demand, when Cordova is used. This follows up on #9213, which added it back to the 'dev-bundle-tool-package.js' and updates it in the new location. Ref: #9213 Ref: 073f241 cc @skirunman.
I think I just typo-ed that patch version right before I committed it. It certainly should have been 7.1.0. :( Ref: #9213 cc @skirunman.
The changes made in #9213 were seemingly innocent, but when merging I missed the fact that the 'cordova-lib' package bump was done to a new entry on the 'dev bundle', rather than on the `CORDOVA_DEV_BUNDLE_VERSIONS` in tools/cordova/index.js which, as of #8976, is responsible for auto-installing Cordova when it is used rather than including it in the pre-packaged 'dev bundle'. That mistake was fixed with 958c44f and d6adc1b, but not before it caused the Cordova tests to falsely pass on the PR since it was functionally still testing the previous version of Cordova, 7.0.0. Unfortunately, one of the changes in the 7.1.0 was the deprecation of an API we use within Meteor: the `raw` API on `cordova_lib`. Luckily, as seen on the following commit, that change was merely a re-organizational commit and still provides us access to that API by simply removing the `raw.` segment and accessing the various methods directly: apache/cordova-lib@90b6857 Never saw that deprecation message, but we certainly saw the failure in CI: https://circleci.com/gh/meteor/meteor/10412. With any luck, this commit/PR will fix the problem.
The changes made in #9213 were seemingly innocent, but when merging I missed the fact that the 'cordova-lib' package bump was done to a new entry on the 'dev bundle', rather than on the `CORDOVA_DEV_BUNDLE_VERSIONS` in tools/cordova/index.js which, as of #8976, is responsible for auto-installing Cordova when it is used rather than including it in the pre-packaged 'dev bundle'. That mistake was fixed with 958c44f and d6adc1b, but not before it caused the Cordova tests to falsely pass on the PR since it was functionally still testing the previous version of Cordova, 7.0.0. Unfortunately, one of the changes in the 7.1.0 was the deprecation of an API we use within Meteor: the `raw` API on `cordova_lib`. Luckily, as seen on the following commit, that change was merely a re-organizational commit and still provides us access to that API by simply removing the `raw.` segment and accessing the various methods directly: apache/cordova-lib@90b6857 Never saw that deprecation message, but we certainly saw the failure in CI: https://circleci.com/gh/meteor/meteor/10412. With any luck, this commit/PR will fix the problem.
Closes meteor/meteor-feature-requests#196
This is WIP as I did not build and update the bundle version so hoping this can be done by someone else.
Also, was not sure how to deal with the deprecated Cordova plugins that are still in our build, but did mark them as deprecated and could be removed in the future.