Refactor handlers

[thani-sh]

No description provided.

[arunoda]

Machan, how about this one. Then testing and everything will be simple.

type MessageHandle func(*Server, Response, Message) error

// These are the handles

func connectHandle(s *Server, res Response, m Message) error {
 return res.WriteJSON(map[string]string{
   "msg":     "connected",
   "session": random.Id(17),
 })
}

func pingHandle(s *Server, res Response, m Message) error {
 ...
}

func methodHandle(s *Server, res Response, m Message) error {
 ...
}

DDPHandlers:= map[string]MessageHandle {
  "connect": connectHandle,
  "ping": pingHandle,
  "method": methodHandle
}

// In the server.

if handler, ok := DDPHandlers[msg.Msg]; ok {
  go handler(s, res, msg)
} else {
  break
}

[thani-sh]

Yeah. Code is a lot simpler this way.

On Wed, Feb 18, 2015, 20:48 Arunoda Susiripala notifications@github.com
wrote:

Machan, how about this one. Then testing and everything will be simple.

type MessageHandle func(*Server, Response, Message) error
// These are the handles
func connectHandle(s *Server, res Response, m Message) error {
return res.WriteJSON(map[string]string{
"msg": "connected",
"session": random.Id(17),
})
}
func pingHandle(s *Server, res Response, m Message) error {
...
}
func methodHandle(s *Server, res Response, m Message) error {
...
}
DDPHandlers := map[string]MessageHandle{
"connect": connectHandle,
"ping": pingHandle,
"method": methodHandle
}
// In the server.
if handler, ok := DDPHandlers[msg.Msg]; ok {
go handler(s, res, msg)
} else {
break
}

—
Reply to this email directly or view it on GitHub
#3 (comment).

[arunoda]

great.

On Wed Feb 18 2015 at 9:18:03 PM Muhammed Thanish notifications@github.com
wrote:

Yeah. Code is a lot simpler this way.

On Wed, Feb 18, 2015, 20:48 Arunoda Susiripala notifications@github.com
wrote:

Machan, how about this one. Then testing and everything will be simple.

type MessageHandle func(*Server, Response, Message) error
// These are the handles
func connectHandle(s *Server, res Response, m Message) error {
return res.WriteJSON(map[string]string{
"msg": "connected",
"session": random.Id(17),
})
}
func pingHandle(s *Server, res Response, m Message) error {
...
}
func methodHandle(s *Server, res Response, m Message) error {
...
}
DDPHandlers := map[string]MessageHandle{
"connect": connectHandle,
"ping": pingHandle,
"method": methodHandle
}
// In the server.
if handler, ok := DDPHandlers[msg.Msg]; ok {
go handler(s, res, msg)
} else {
break
}

—
Reply to this email directly or view it on GitHub
#3 (comment).

—
Reply to this email directly or view it on GitHub
#3 (comment).

[thani-sh]

Added some integration tests

[arunoda]

duplicate.