Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow integration #221

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

timbrandin
Copy link

πŸ‘ for Flow Router and Flow Layout – though it needs some work :)

@omeid
Copy link

omeid commented Jun 19, 2015

πŸ‘ Specially if one wants to use fast-render.

@@ -250,7 +250,7 @@ To get a nice Ionic styled list item wrap your content in a `ionItem` block temp

#### Path and Link Examples

Meteor uses Iron:Router. Most are familiar with Iron:Router's [pathFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#pathfor) and [urlFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#urlfor) helpers. Meteoric lets you tap into those helpers from within `ionItem` or ignore them, the choice is yours.
Meteor uses Iron:FlowRouter. Most are familiar with Iron:FlowRouter's [pathFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#pathfor) and [urlFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#urlfor) helpers. Meteoric lets you tap into those helpers from within `ionItem` or ignore them, the choice is yours.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As flow-router doesn't provides these methods natively, the current option seems to be @arillo's meteor-flow-router-helpers.

@omeid
Copy link

omeid commented Jun 28, 2015

Ping. Any progress here?

@elGusto
Copy link

elGusto commented Jul 1, 2015

This is really not something that can be merged like that.
I don't think @nickw would like to let go of the iron router integration just to replace it by flow (and then the next popular router). We should restructure the package, either to make two seperate packages, one for IR, the other for FR, either we redesign to have a core package with pluggable router integretion packages (which would be the best imo in the case of new (or from MDG) router).

@omeid
Copy link

omeid commented Jul 1, 2015

I didn't ask for this pull request to be merged. Progress can be talks about the design. :)

And you're right, restructuring to have different routers in their packages seems to be the way to go, it will also be inline with how MDG is planning to go with useraccounts, meteor-useraccounts/core#308.

@elGusto
Copy link

elGusto commented Jul 9, 2015

@nickw what do you think ?
I'm happy to help with the refactoring, if you have some specific ideas let me know. I'll start working on this soon.

@nickw
Copy link

nickw commented Jul 9, 2015

@elGusto I'm open to refactoring to allow multiple routers, but I don't have any time right now to contribute unfortunately. Also, if there are clear advantages to Flow Router over Iron Router I'm open to just switching them out as well.

@omeid
Copy link

omeid commented Jul 9, 2015

Please don't drop Iron Router integration.
Beside breaking current Meteoric projects it will also make switching non-meteoric Iron:router based projects much harder.

The advantage of routers over each other is also pretty subjective and case specific.

I think MDG is working on an "official" router,or there is at least talks about it, so then there would be changes yet again...

I think it is best to make the router handling modular similar to useraccounts approach as linked in my previous comment.

@timothyarmes
Copy link

@elGusto Just wondering if you'd started working on a refactoring?

@rclai
Copy link
Contributor

rclai commented Jul 27, 2015

Perhaps making it router agnostic is more palatable?

@timothyarmes
Copy link

@rcmai that's excellent.

@timbrandin
Copy link
Author

Wow, cool Lai!

I can't wait until we also make meteoric framework agnostic (react or
blaze) ;)

2015-07-27 17:34 GMT+02:00 timothyarmes notifications@github.com:

@rcmai that's excellent.

β€”
Reply to this email directly or view it on GitHub
#221 (comment)
.

Cheers,
// Tim Brandin @timbrandin https://twitter.com/#!/timbrandin
http://timbrandin.com
http://studiointeract.com

@elGusto
Copy link

elGusto commented Aug 12, 2015

Just saw this today https://github.com/nicolaslopezj/meteor-router-layer.
Prepare for Meteoric with router-layer on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants