-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow integration #221
base: master
Are you sure you want to change the base?
Flow integration #221
Conversation
π Specially if one wants to use fast-render. |
@@ -250,7 +250,7 @@ To get a nice Ionic styled list item wrap your content in a `ionItem` block temp | |||
|
|||
#### Path and Link Examples | |||
|
|||
Meteor uses Iron:Router. Most are familiar with Iron:Router's [pathFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#pathfor) and [urlFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#urlfor) helpers. Meteoric lets you tap into those helpers from within `ionItem` or ignore them, the choice is yours. | |||
Meteor uses Iron:FlowRouter. Most are familiar with Iron:FlowRouter's [pathFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#pathfor) and [urlFor](https://github.com/EventedMind/iron-router/blob/devel/Guide.md#urlfor) helpers. Meteoric lets you tap into those helpers from within `ionItem` or ignore them, the choice is yours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As flow-router doesn't provides these methods natively, the current option seems to be @arillo's meteor-flow-router-helpers.
Ping. Any progress here? |
This is really not something that can be merged like that. |
I didn't ask for this pull request to be merged. Progress can be talks about the design. :) And you're right, restructuring to have different routers in their packages seems to be the way to go, it will also be inline with how MDG is planning to go with useraccounts, meteor-useraccounts/core#308. |
@nickw what do you think ? |
@elGusto I'm open to refactoring to allow multiple routers, but I don't have any time right now to contribute unfortunately. Also, if there are clear advantages to Flow Router over Iron Router I'm open to just switching them out as well. |
Please don't drop Iron Router integration. The advantage of routers over each other is also pretty subjective and case specific. I think MDG is working on an "official" router,or there is at least talks about it, so then there would be changes yet again... I think it is best to make the router handling modular similar to |
@elGusto Just wondering if you'd started working on a refactoring? |
Perhaps making it router agnostic is more palatable? |
@rcmai that's excellent. |
Wow, cool Lai! I can't wait until we also make meteoric framework agnostic (react or 2015-07-27 17:34 GMT+02:00 timothyarmes notifications@github.com:
Cheers, |
Just saw this today https://github.com/nicolaslopezj/meteor-router-layer. |
Conflicts: components/ionTab/ionTab.js components/ionTabs/ionTabs.js package.js
π for Flow Router and Flow Layout β though it needs some work :)