Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEP -> CNEMC #1202

Merged
merged 5 commits into from
Jun 14, 2024
Merged

MEP -> CNEMC #1202

merged 5 commits into from
Jun 14, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Jun 13, 2024

Change Summary

All references to MEP have been changed to CNEMC as this is the new name for the network.

Related issue number

closes #1176

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • With the exception to test_load_berlin as described in this PR
  • Tests pass on CI
  • with the exception of code coverage which is not relevant for this PR
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added this to the m2024-07 milestone Jun 13, 2024
@lewisblake lewisblake mentioned this pull request Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (ac80b76) to head (6e100b5).
Report is 511 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1202      +/-   ##
============================================
- Coverage     79.31%   79.31%   -0.01%     
============================================
  Files           131      131              
  Lines         20230    20231       +1     
============================================
  Hits          16046    16046              
- Misses         4184     4185       +1     
Flag Coverage Δ
unittests 79.31% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review June 14, 2024 07:57
@thorbjoernl
Copy link
Collaborator

Should the following lines in paths.ini also be changed?

L136: MEP = MEP
L176: MEP = 2013

@lewisblake
Copy link
Member Author

@jgriesfeller my vote is to keep the file path in paths.ini the same until the download location on the CAMS Validation Server changes, and then we change the entire name in the AEROCOM_OBSDATA database.

@lewisblake lewisblake merged commit 331944d into main-dev Jun 14, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the cnemc1176 branch June 14, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename MEP instances into CNEMC
2 participants