-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AeroVal config documentation example #495
Conversation
… cleanup some unused code and docs in AERONET readers
…ew custom exception
Codecov Report
@@ Coverage Diff @@
## main-dev #495 +/- ##
============================================
+ Coverage 76.61% 76.64% +0.03%
============================================
Files 97 97
Lines 17358 17357 -1
============================================
+ Hits 13299 13304 +5
+ Misses 4059 4053 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…files in AeroVal (both json and colocated data files)
@dulte and @jgriesfeller and @AugustinMortier please be aware of the changes here, I found some bugs and inconsistencies in the variable handling for the output files when creating the example config. The problem is that pyaerocom was using the AeroCom variable name for the output files and not the input variable name, which resulted in AeroVal not displaying "ang4487csaer" from NorESM2 in the model maps plots, because "ang4487csaer" is an alias for "ang4487aer". I think this affects only cases where alias variables are used, and it is good that this was detected now, since this variable mappings is always a mess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) Wonderful documentation of the config. I will use it to document a more advanced example :)
This PR adds an AeroVal example configuration script in the ReadTheDocs page, that explains the main setup and options.
It also fixes a few issues that were detected after release of v0.12.1 when trying to run the example setup, e.g. #494.