Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests with/without exceptions #526

Merged
merged 96 commits into from
Dec 9, 2021

Conversation

avaldebe
Copy link
Collaborator

follow up to #397

@avaldebe avaldebe added enhancement ✨ New feature or request testing labels Nov 22, 2021
@avaldebe avaldebe self-assigned this Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #526 (57554f7) into main-dev (a4a35d4) will decrease coverage by 0.00%.
The diff coverage is 93.33%.

❗ Current head 57554f7 differs from pull request most recent head 32cd682. Consider uploading reports for the commit 32cd682 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           main-dev     #526      +/-   ##
============================================
- Coverage     76.66%   76.66%   -0.01%     
============================================
  Files            97       97              
  Lines         17490    17494       +4     
============================================
+ Hits          13409    13412       +3     
- Misses         4081     4082       +1     
Flag Coverage Δ
unittests 76.66% <93.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/plot/heatmaps.py 100.00% <ø> (ø)
pyaerocom/utils.py 87.71% <90.90%> (-0.96%) ⬇️
pyaerocom/_lowlevel_helpers.py 82.48% <100.00%> (ø)
pyaerocom/colocation_auto.py 81.83% <0.00%> (-0.63%) ⬇️
pyaerocom/io/read_earlinet.py 88.47% <0.00%> (-0.34%) ⬇️
pyaerocom/griddeddata.py 61.89% <0.00%> (-0.17%) ⬇️
pyaerocom/colocateddata.py 81.36% <0.00%> (ø)
pyaerocom/io/readgridded.py 72.54% <0.00%> (ø)
pyaerocom/aeroval/experiment_output.py 87.41% <0.00%> (+0.22%) ⬆️
pyaerocom/plot/mapping.py 96.52% <0.00%> (+0.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a35d4...32cd682. Read the comment docs.

@avaldebe avaldebe force-pushed the split-raise-tests branch 4 times, most recently from 1e502c5 to 0207d4b Compare November 29, 2021 08:05
@avaldebe avaldebe marked this pull request as ready for review November 30, 2021 14:18
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked only at a few files thoroughly, but since the CI does not throw errors I trust you that everything is working

@avaldebe avaldebe merged commit c906508 into metno:main-dev Dec 9, 2021
@avaldebe avaldebe deleted the split-raise-tests branch December 9, 2021 15:02
@avaldebe avaldebe restored the split-raise-tests branch December 9, 2021 15:03
@avaldebe avaldebe deleted the split-raise-tests branch December 9, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants