Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the AERONET reading more fault tolerable; add possibility to read gzipped files #538

Merged
merged 15 commits into from
Dec 14, 2021

Conversation

jgriesfeller
Copy link
Member

Basically a new try for a fix of #518 done because I messed up the branch after @avaldebe merged the source run through black and isort.
No different functionality compared to #527

@jgriesfeller jgriesfeller changed the title make the reading more fault tolerable; add possibility to read gzipped files make the AERONET reading more fault tolerable; add possibility to read gzipped files Dec 13, 2021
@jgriesfeller jgriesfeller self-assigned this Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #538 (947837e) into main-dev (c906508) will increase coverage by 0.09%.
The diff coverage is 89.65%.

❗ Current head 947837e differs from pull request most recent head 9f9ad1a. Consider uploading reports for the commit 9f9ad1a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           main-dev     #538      +/-   ##
============================================
+ Coverage     76.69%   76.78%   +0.09%     
============================================
  Files            97       97              
  Lines         17494    17525      +31     
============================================
+ Hits          13417    13457      +40     
+ Misses         4077     4068       -9     
Flag Coverage Δ
unittests 76.78% <89.65%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/access_testdata.py 78.94% <ø> (ø)
pyaerocom/io/readaeronetbase.py 71.42% <88.88%> (+5.94%) ⬆️
pyaerocom/io/read_aeronet_sunv3.py 90.44% <89.47%> (-0.64%) ⬇️
pyaerocom/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c906508...9f9ad1a. Read the comment docs.

Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have small suggestions, mostly a test that raises the new exception.
You can go ahead and merge if you think I'm nitpicking.

tests/io/test_read_aeronet_sunv3_all_points.py Outdated Show resolved Hide resolved
tests/io/test_read_aeronet_sunv3_all_points.py Outdated Show resolved Hide resolved
tests/io/test_read_aeronet_sunv3_all_points.py Outdated Show resolved Hide resolved
pyaerocom/exceptions.py Show resolved Hide resolved
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ready to merge

@jgriesfeller jgriesfeller merged commit e4455d8 into main-dev Dec 14, 2021
@jgriesfeller jgriesfeller deleted the griesie_fix518_2 branch December 14, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants