Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes sspm10 to be ssf+ssc #579

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Changes sspm10 to be ssf+ssc #579

merged 1 commit into from
Feb 2, 2022

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Feb 2, 2022

Fix for issue #573

@dulte dulte requested a review from avaldebe February 2, 2022 10:18
@dulte
Copy link
Collaborator Author

dulte commented Feb 2, 2022

The 0.13 should be there for sspm2.5, but I also think sspm10 is wrong. So I've made it so sspm10 = ssf + ssc now

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #579 (00c652d) into main-dev (4a3cf5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main-dev     #579   +/-   ##
=========================================
  Coverage     76.98%   76.98%           
=========================================
  Files            97       97           
  Lines         17509    17509           
=========================================
  Hits          13479    13479           
  Misses         4030     4030           
Flag Coverage Δ
unittests 76.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/io/read_mscw_ctm.py 95.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3cf5f...00c652d. Read the comment docs.

Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ready to merge 💥

@dulte dulte merged commit 9911d3f into main-dev Feb 2, 2022
@dulte dulte deleted the fix-seasalt branch February 2, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants