-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix o3max #627
Conversation
Codecov Report
@@ Coverage Diff @@
## main-dev #627 +/- ##
============================================
- Coverage 76.94% 76.90% -0.04%
============================================
Files 98 98
Lines 17635 17649 +14
============================================
+ Hits 13569 13573 +4
- Misses 4066 4076 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very talented programmer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is even better!
calc_conNtno3, | ||
calc_vmrox, | ||
calc_vmrno2, | ||
calc_vmrox, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change the order?
what is the plan for reading plain |
Makes it so that the obs readers read o3max as o3. It is not a perfect fix, but at least a fix.
It works with EBAS