Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix o3max #627

Merged
merged 10 commits into from
Apr 28, 2022
Merged

Fix o3max #627

merged 10 commits into from
Apr 28, 2022

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Apr 22, 2022

Makes it so that the obs readers read o3max as o3. It is not a perfect fix, but at least a fix.

It works with EBAS

@avaldebe avaldebe added this to the v0.13.0 milestone Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #627 (668a3b0) into main-dev (5c6334b) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##           main-dev     #627      +/-   ##
============================================
- Coverage     76.94%   76.90%   -0.04%     
============================================
  Files            98       98              
  Lines         17635    17649      +14     
============================================
+ Hits          13569    13573       +4     
- Misses         4066     4076      +10     
Flag Coverage Δ
unittests 76.90% <33.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/aeroval/glob_defaults.py 100.00% <ø> (ø)
pyaerocom/io/read_ebas.py 88.08% <ø> (ø)
pyaerocom/io/read_mscw_ctm.py 95.08% <ø> (ø)
pyaerocom/aux_var_helpers.py 57.89% <9.09%> (-3.81%) ⬇️
pyaerocom/io/read_eea_aqerep_base.py 55.20% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6334b...668a3b0. Read the comment docs.

@WillemVanCaspel WillemVanCaspel marked this pull request as ready for review April 28, 2022 08:43
Copy link
Collaborator

@WillemVanCaspel WillemVanCaspel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very talented programmer!

Copy link
Collaborator

@WillemVanCaspel WillemVanCaspel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is even better!

Comment on lines 21 to +23
calc_conNtno3,
calc_vmrox,
calc_vmrno2,
calc_vmrox,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the order?

@avaldebe
Copy link
Collaborator

what is the plan for reading plain O3 as O3?

@dulte dulte merged commit 42d2acf into main-dev Apr 28, 2022
@dulte dulte deleted the fix_o3max branch April 28, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants