-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable variable ratpm10pm25 via aeroval #641
Conversation
Codecov Report
@@ Coverage Diff @@
## main-dev #641 +/- ##
============================================
+ Coverage 76.89% 76.90% +0.01%
============================================
Files 98 98
Lines 17644 17643 -1
============================================
+ Hits 13568 13569 +1
+ Misses 4076 4074 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -48,6 +48,10 @@ | |||
["concoa", "ug C/m3", "ug m-3", 1.0], | |||
["concoc", "ug C/m3", "ug m-3", 1.0], | |||
["conctc", "ug C/m3", "ug m-3", 1.0], | |||
# a little hacky for ratpm10pm25... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed because pyaerocom always tries to convert evrerything into the target unit first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate some tests to cover the new unit helpers and the NotImplementedError
obs filter
except ( | ||
VarNotAvailableError, | ||
TimeMatchError, | ||
DataCoverageError, | ||
NotImplementedError, | ||
) as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this lines are covered somewhere on the test suite, but it would be great to test that NotImplementedError
can be used to filter obs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to test these exceptions effectively. Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only ideas I have right now is a fake reader that throws these exceptions or a fabricated data set. Both takes some time to create.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will extend these exceptions for the next release (e.g. with the exception raised when a station moved more than a kilometer).
How about postponing that test until then?
after speaking with @avaldebe : merging |
This PR makes it possible to calculate the variable ratpm10pm25 via aeroval for observation.
The minimum snippet to use is this (example for AirNow obs network):
Tests are still missing