Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace WORLD with ALL in used filter names #659

Merged
merged 11 commits into from
Jun 7, 2022
Merged

Conversation

jgriesfeller
Copy link
Member

and using only one constant to store the value

@jgriesfeller jgriesfeller self-assigned this May 31, 2022
@jgriesfeller jgriesfeller linked an issue May 31, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #659 (3d3ebd8) into main-dev (82d4333) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff            @@
##           main-dev     #659   +/-   ##
=========================================
  Coverage     76.90%   76.91%           
=========================================
  Files            98       98           
  Lines         17647    17653    +6     
=========================================
+ Hits          13571    13577    +6     
  Misses         4076     4076           
Flag Coverage Δ
unittests 76.91% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/colocation.py 71.81% <ø> (ø)
pyaerocom/region.py 62.69% <75.00%> (+0.29%) ⬆️
pyaerocom/aeroval/coldatatojson_helpers.py 71.91% <83.33%> (+0.04%) ⬆️
pyaerocom/access_testdata.py 79.16% <100.00%> (ø)
pyaerocom/colocation_auto.py 81.88% <100.00%> (+0.02%) ⬆️
pyaerocom/config.py 83.39% <100.00%> (ø)
pyaerocom/filter.py 87.03% <100.00%> (+0.12%) ⬆️
pyaerocom/region_defs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d4333...3d3ebd8. Read the comment docs.

@jgriesfeller jgriesfeller marked this pull request as ready for review June 2, 2022 10:59
@jgriesfeller
Copy link
Member Author

@AugustinMortier as soon as you have finished your testing and can confirm that it's working for the web interface, I can start the review

@AugustinMortier
Copy link
Member

I confirm that the web interface now supports ALL.

@jgriesfeller jgriesfeller changed the title 1st try to replace WORLD with ALL in used filter names replace WORLD with ALL in used filter names Jun 7, 2022
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁🏎️ ready to merge

@jgriesfeller jgriesfeller merged commit db4baf8 into main-dev Jun 7, 2022
@jgriesfeller jgriesfeller deleted the griesie_fix_645 branch June 7, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename WORLD region to ALL
3 participants