Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IndexError on xarray 2022.6.0 #711

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

avaldebe
Copy link
Collaborator

@avaldebe avaldebe commented Aug 2, 2022

close #710

@avaldebe avaldebe changed the title fix IndexError on xarray 2022.6.0, close #710 fix IndexError on xarray 2022.6.0 Aug 2, 2022
@avaldebe avaldebe self-assigned this Aug 2, 2022
@avaldebe avaldebe added the dependencies Issues related to pyaerocom dependencies label Aug 2, 2022
@avaldebe avaldebe added this to the v0.13.2 milestone Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #711 (67109d1) into main-dev (bee5311) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           main-dev     #711      +/-   ##
============================================
- Coverage     77.38%   77.37%   -0.01%     
============================================
  Files            97       97              
  Lines         17556    17559       +3     
============================================
+ Hits          13585    13587       +2     
- Misses         3971     3972       +1     
Flag Coverage Δ
unittests 77.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/aeroval/coldatatojson_helpers.py 68.65% <100.00%> (+0.05%) ⬆️
pyaerocom/config.py 83.56% <0.00%> (-0.17%) ⬇️
pyaerocom/io/read_eea_aqerep_base.py 84.70% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee5311...67109d1. Read the comment docs.

@avaldebe avaldebe marked this pull request as ready for review August 2, 2022 09:25
@lewisblake
Copy link
Member

Looks good to merge. Thanks for taking care of this!

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@avaldebe avaldebe merged commit 28314a6 into metno:main-dev Aug 2, 2022
@avaldebe avaldebe deleted the fix-corr branch August 2, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues related to pyaerocom dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail with xarray 2022.6.0
2 participants