Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually load data in AirNow reader to avoid pandas error #893

Closed
wants to merge 4 commits into from

Conversation

lewisblake
Copy link
Member

Designed to close #890

I can't imagine this is the most elegant solution, but it will take care of the new encoding issues in with pandas.read_csv(). It would be worth investigating the performance benefit of putting this in a try-except block where we try pandas, but if that fails, we use this method instead.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 93.33% and no project coverage change.

Comparison is base (2104317) 80.42% compared to head (537933a) 80.43%.
Report is 1 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev     #893   +/-   ##
=========================================
  Coverage     80.42%   80.43%           
=========================================
  Files           101      101           
  Lines         17433    17446   +13     
=========================================
+ Hits          14021    14033   +12     
- Misses         3412     3413    +1     
Flag Coverage Δ
unittests 80.43% <93.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pyaerocom/io/read_airnow.py 97.71% <93.33%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake closed this Sep 4, 2023
@lewisblake lewisblake deleted the fix890 branch February 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AirNow reader crashing
1 participant