Support for schemas as map values

[acrao]

I'm having some difficulty integrating a schema map using maybe in the map value. Here is the schema definition for the data that my API returns :

(def Boundary
  {:type (enum "MultiPolygon" "Polygon" "MultiPoint" "Point")
   :coordinates [Any]}) 

(def ReturnValue
  {:boundary (maybe Boundary) ;; can be of type Boundary or nil. In either case, 
                                                   ;; the key should always exist
   .....}

Here is the exception I'm running into when starting my server :

java.lang.IllegalArgumentException: error converting to json schema [:boundary (maybe {:type (enum "Point" "Polygon" "MultiPolygon" "MultiPoint"), :coordinates [Any]})]
    at ring.swagger.json_schema$properties$iter__10215__10219$fn__10220$fn__10228.invoke(json_schema.clj:117)
    at ring.swagger.json_schema$properties$iter__10215__10219$fn__10220.invoke(json_schema.clj:113)
    at clojure.lang.LazySeq.sval(LazySeq.java:40)
    at clojure.lang.LazySeq.seq(LazySeq.java:49)
    at clojure.lang.Cons.next(Cons.java:39)
    at clojure.lang.RT.next(RT.java:598)
......

Caused by: java.lang.IllegalArgumentException: don't know how to create json-type of: {:type (enum "Point" "Polygon" "MultiPolygon" "MultiPoint"), :coordinates [Any]}
    at ring.swagger.json_schema$eval10210$fn__10211.invoke(json_schema.clj:95)
    at clojure.lang.MultiFn.invoke(MultiFn.java:227)
    at ring.swagger.json_schema$__GT_json.doInvoke(json_schema.clj:47)
    at clojure.lang.RestFn.invoke(RestFn.java:410)
    at ring.swagger.json_schema$eval10190$fn__10191.invoke(json_schema.clj:86)
    at clojure.lang.MultiFn.invoke(MultiFn.java:227)
    at ring.swagger.json_schema$__GT_json.doInvoke(json_schema.clj:47)
    at clojure.lang.RestFn.invoke(RestFn.java:410)
    at ring.swagger.json_schema$properties$iter__10215__10219$fn__10220$fn__10228.invoke(json_schema.clj:113)
    ... 94 more

I'm using [metosin/compojure-api "0.16.2"]. I'm not quite sure what I'm missing here. Any pointers as to how I can get around this? Do I need to define a custom json-schema?

[Deraen]

Define the schemas using schema.core/defschema. It attaches meta-data (name) to the maps which we need to generate the json-schema.

[Deraen]

Though I think this should still work with the plain defs, ring-swagger should just use generated names for the schemas instead.

Looking at the code, I think there might be problem with handing non-named schemas with predicates like s/Maybe.

[ikitommi]

Sorry it took so long to fix, should work now with named schemas (in 0.16.6):

(defschema Boundary
  {:type (enum "MultiPolygon" "Polygon" "MultiPoint" "Point")
   :coordinates [Any]}) 

(defschema ReturnValue
  {:boundary (maybe Boundary)})

tests here https://github.com/metosin/ring-swagger/blob/master/test/ring/swagger/core_test.clj#L171

does not work with anonymous schemas (https://github.com/metosin/ring-swagger/blob/master/test/ring/swagger/core_test.clj#L341), will try to fix that later

cheers,

Tommi

[ikitommi]

Fixed now, by @Deraen.

See https://github.com/metosin/compojure-api/blob/master/test/compojure/api/core_integration_test.clj#L535-L566

Will wrap the sub-walker as a separate lib so that it can be extended easier.