Merge Bloom Core

[ludtkemorgan]

Pull Request Template

Issue Overview

This PR addresses #issue

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

This pulls in the latest 16 commits from core. The biggest change is the upgrade to React 18 and also Next 13

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

• My code follows the style guidelines of this project
• I have added QA notes to the issue with applicable URLs
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have run yarn generate:client and/or created a migration if I made backend changes that require them
• I have exported any new pieces added to ui-components
• My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
• Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

• Read and understand the issue, and ensure the author has added QA notes
• Review the code itself from a style point of view
• Pull the changes down locally and test that the acceptance criteria is met
• Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
• Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

[ludtkemorgan]

I'm investigating the broken partner unit test. It passes locally, but not on github actions

[lisunshiny]

@ludtkemorgan qq is it normal that yarning results in lockfile changes?

[ludtkemorgan]

@ludtkemorgan qq is it normal that yarning results in lockfile changes?

Yes, when running yarn it uses the lockfile unless something on the package.json file has changed. In that case it also updates the lockfile. This is only done locally as theoretically it should be updated with the commit

[lisunshiny]

hey @ludtkemorgan ! some heads up and some qs:

1. I did some testing on public site and partners portal, some stuff is broken on the public site but I don't think its related to this PR so that overall seems fine
2. I tried doing some cloudinary uploads, which involved logging in as an admin which I assume both tests the new auth cookies and the shared-services stuff.

Qs for you:

• Did you run the integration tests on the public and partners site? We don't have them in our github actions and I still can't get a clean run locally. Its possible that they are failing on main rn but curious to see what the output is regardless
• Is there anything you need from us before taking the PR out of draft and ready for review/merge?

[ludtkemorgan]

@lisunshiny I did run the integration tests. The public ones work, but the partner fails for reason unrelated to these changes. Mostly around how we expect the "San Jose" jurisdiction for a few tests that doesn't exist in the doorway seeded data.

Nothing is preventing this from going out of Draft. I'll change that now!

[ludtkemorgan]

@lisunshiny logging into partners tests the cookies. It should also work on multiple tabs, as in logging in and then opening a new tab of the app and you should still be logged in.