-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add startDate to open house submit event #3399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ludtkemorgan
approved these changes
Apr 17, 2023
YazeedLoonat
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chriscasto
added a commit
to metrotranscom/doorway
that referenced
this pull request
Apr 20, 2023
* fix: user export fixes (bloom-housing#3371) * fix: user export fixes * fix: update error message alert * chore(release): version - @bloom-housing/partners@7.10.1 * feat: upgrade react to 18 (bloom-housing#3360) * feat: upgrade react to 18 * feat: upgrade cypress to 12 for public * feat: upgrade cypress for partners * fix: update configs * fix: update partner cypress tests * fix: review comments * fix: fix flaky cypress test * chore(release): version - @bloom-housing/backend-core@7.12.0 - @bloom-housing/shared-helpers@7.6.0 - @bloom-housing/partners@7.11.0 - @bloom-housing/public@7.5.0 * fix: program/preference keys length uncap (bloom-housing#3376) * fix: program/preference keys length uncap * fix: updates per pr comments * chore(release): version - @bloom-housing/backend-core@7.12.1 - @bloom-housing/shared-helpers@7.6.1 - @bloom-housing/partners@7.11.1 - @bloom-housing/public@7.5.1 * feat: upgrade nextjs to 13 (bloom-housing#3375) * feat: upgrade nextjs to 13 * fix: attempt to get cypress test working * chore(release): version - @bloom-housing/partners@7.12.0 - @bloom-housing/public@7.6.0 * feat: changing auth over to cookies (bloom-housing#3357) * fix: resolves issues around markedAsDuplicate (bloom-housing#3373) * chore(release): version - @bloom-housing/backend-core@7.13.0 - @bloom-housing/shared-helpers@7.7.0 - @bloom-housing/partners@7.13.0 - @bloom-housing/public@7.7.0 * fix: react type errors (bloom-housing#3382) * chore(release): version - @bloom-housing/shared-helpers@7.7.1 - @bloom-housing/partners@7.13.1 - @bloom-housing/public@7.7.1 * refactor: add cloudinary fxn to partners (bloom-housing#3393) * fix: remove max length from extra data app fields (bloom-housing#3394) * refactor: uptake seeds FormErrorMessage (bloom-housing#3369) * fix: type fix for token * fix: lock file and hydration fixes * fix: add startDate to open house submit event (bloom-housing#3399) * fix: add three new fields to base view (bloom-housing#3406) * feat: removing sensative info from leasing agent (bloom-housing#3409) * feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests * chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updates around cookies (bloom-housing#3405) * fix: updates around cookies * fix: creating new migration for token -> code --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github.context.workflow <github-actions@github.com> Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Casto <23032560+chriscasto@users.noreply.github.com>
ifranch
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Apr 21, 2023
* fix: user export fixes (bloom-housing#3371) * fix: user export fixes * fix: update error message alert * chore(release): version - @bloom-housing/partners@7.10.1 * feat: upgrade react to 18 (bloom-housing#3360) * feat: upgrade react to 18 * feat: upgrade cypress to 12 for public * feat: upgrade cypress for partners * fix: update configs * fix: update partner cypress tests * fix: review comments * fix: fix flaky cypress test * chore(release): version - @bloom-housing/backend-core@7.12.0 - @bloom-housing/shared-helpers@7.6.0 - @bloom-housing/partners@7.11.0 - @bloom-housing/public@7.5.0 * fix: program/preference keys length uncap (bloom-housing#3376) * fix: program/preference keys length uncap * fix: updates per pr comments * chore(release): version - @bloom-housing/backend-core@7.12.1 - @bloom-housing/shared-helpers@7.6.1 - @bloom-housing/partners@7.11.1 - @bloom-housing/public@7.5.1 * feat: upgrade nextjs to 13 (bloom-housing#3375) * feat: upgrade nextjs to 13 * fix: attempt to get cypress test working * chore(release): version - @bloom-housing/partners@7.12.0 - @bloom-housing/public@7.6.0 * feat: changing auth over to cookies (bloom-housing#3357) * fix: resolves issues around markedAsDuplicate (bloom-housing#3373) * chore(release): version - @bloom-housing/backend-core@7.13.0 - @bloom-housing/shared-helpers@7.7.0 - @bloom-housing/partners@7.13.0 - @bloom-housing/public@7.7.0 * fix: react type errors (bloom-housing#3382) * chore(release): version - @bloom-housing/shared-helpers@7.7.1 - @bloom-housing/partners@7.13.1 - @bloom-housing/public@7.7.1 * refactor: add cloudinary fxn to partners (bloom-housing#3393) * fix: remove max length from extra data app fields (bloom-housing#3394) * refactor: uptake seeds FormErrorMessage (bloom-housing#3369) * fix: type fix for token * fix: lock file and hydration fixes * fix: add startDate to open house submit event (bloom-housing#3399) * fix: add three new fields to base view (bloom-housing#3406) * feat: removing sensative info from leasing agent (bloom-housing#3409) * feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests * chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updates around cookies (bloom-housing#3405) * fix: updates around cookies * fix: creating new migration for token -> code --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github.context.workflow <github-actions@github.com> Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Casto <23032560+chriscasto@users.noreply.github.com>
ludtkemorgan
pushed a commit
to housingbayarea/bloom
that referenced
this pull request
May 2, 2023
ludtkemorgan
pushed a commit
to housingbayarea/bloom
that referenced
this pull request
May 9, 2023
ludtkemorgan
added a commit
to housingbayarea/bloom
that referenced
this pull request
May 18, 2023
* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358) * feat: upgrade react to 18 (bloom-housing#3360) * feat: upgrade nextjs to 13 (bloom-housing#3375) * feat: upgrade nextjs to 13 * fix: attempt to get cypress test working * feat: changing auth over to cookies (bloom-housing#3357) * fix: resolves issues around markedAsDuplicate (bloom-housing#3373) * fix: react type errors (bloom-housing#3382) * refactor: add cloudinary fxn to partners (bloom-housing#3393) * refactor: uptake seeds FormErrorMessage (bloom-housing#3369) * fix: add startDate to open house submit event (bloom-housing#3399) * fix: add three new fields to base view (bloom-housing#3406) * feat: removing sensative info from leasing agent (bloom-housing#3409) * feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests * chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updates around cookies (bloom-housing#3405) * fix: updates around cookies * fix: creating new migration for token -> code * fix: Searching on the applications table causes the page to crash (bloom-housing#3408) * fix: pass proper value to to_tsquery function * fix: search applications using ILIKE * fix: change where to orWhere * feat: add application search by confirmation code * updates proxy to support access control allow list (bloom-housing#3407) * feat: updates proxy to support access control allow list * fix: remove downstream access-control-allow-origin * fix: update readme for m1 * fix: move purge call to the backend * fix: test fix and add await * fix: moving cache purge to helper --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * fix: escape quote in translation update * fix: add translation for 64 characters error (bloom-housing#3423) * fix: downgrade version of nest axios (bloom-housing#3419) * fix: now removes criteria file if a url is input (bloom-housing#3421) * fix: remove check in test not applicable for hba * fix: update ui-c to latest version (bloom-housing#3420) * fix: update application test * feat: 3291/listing export take 2 (bloom-housing#3424) * fix: functional frontend * fix: hooks and service updates * fix: hitting service file * fix: wip config work * fix: wip config 2 * fix: completed query updates * fix: complete column naming and basic formatting * fix: clean up formatting * fix: wip testing debugging * fix: functional unit tests * fix: cypress tests + formatting * fix: unadded test changes * fix: internal csv testing * fix: exporter test fix * fix: more detailed csv checks * fix: testing + formatting tweaks * fix: exporter testing improvements * fix: updates per pr feedback * fix: match config pattern * fix: add close status option * fix: reset netlify testing * fix: final cleanup * fix: rent type formatting * fix: remove console log * fix: missing state data (bloom-housing#3450) * feat: adding knownError flag * feat: adding knownError flag * fix: partners highlight field on backend error (bloom-housing#3448) * fix: partners highlight field on backend error * fix: community type and disableUnitsAccordion fix * fix: unit type fix for partial units * fix: review comment addressed * fix: phone number fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
#3130 -> this comment
This PR addresses #issue
Description
Previously addressed was only lottery date / time. This PR adds missing field to submit open house event.
How Can This Be Tested/Reviewed?
Go to listing in partners -> application process , and create open house event. It should properly display in public site
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.