Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates around cookies #3405

Merged
merged 3 commits into from
Apr 20, 2023
Merged

fix: updates around cookies #3405

merged 3 commits into from
Apr 20, 2023

Conversation

YazeedLoonat
Copy link
Collaborator

Pull Request Template

This PR addresses #issue

  • This change addresses the issue in full

Description

This addresses some issues that came up in bug bash mainly:

  1. locally code is not used throughout instead of a mix of code and token around the mfa code that is sent out. I think a db query that updates this on the hba env needs to be built out

  2. a small fix around the hooks that swr was using. This should reduce the fail rate of the hooks in general, but is not a fix for the useSWR issues we were seeing

  3. added a site alert so the account confirmation alert can be consumed properly after log in

How Can This Be Tested/Reviewed?

create a new user
log in as that user
notice on the page immediately after accepting the terms lets you know that the account was confirmed via a site alert

when you request an mfa code your email should call it a code instead of a token

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@YazeedLoonat YazeedLoonat added the 2 reviews needed Requires 2 more review before ready to merge label Apr 14, 2023
@netlify
Copy link

netlify bot commented Apr 14, 2023 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 0f63233
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6441ac0398c72c0008686fd8
😎 Deploy Preview https://deploy-preview-3405--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ludtkemorgan
ludtkemorgan approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question about the migration

backend/core/src/migration/1675268723433-migration-reset.ts Show resolved Hide resolved
@ludtkemorgan ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Apr 18, 2023
emilyjablonski
emilyjablonski approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Morgan's comment 🍂

@emilyjablonski emilyjablonski removed the 1 review needed Requires 1 more review before ready to merge label Apr 18, 2023
@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Apr 19, 2023
@YazeedLoonat YazeedLoonat merged commit a2d428b into main Apr 20, 2023
chriscasto added a commit to metrotranscom/doorway that referenced this pull request Apr 20, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @chriscasto
Merge Bloom Core (#47)
06cd4e8 
* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

* chore(release): version

 - @bloom-housing/partners@7.10.1

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade react to 18

* feat: upgrade cypress to 12 for public

* feat: upgrade cypress for partners

* fix: update configs

* fix: update partner cypress tests

* fix: review comments

* fix: fix flaky cypress test

* chore(release): version

 - @bloom-housing/backend-core@7.12.0
 - @bloom-housing/shared-helpers@7.6.0
 - @bloom-housing/partners@7.11.0
 - @bloom-housing/public@7.5.0

* fix: program/preference keys length uncap (bloom-housing#3376)

* fix: program/preference keys length uncap

* fix: updates per pr comments

* chore(release): version

 - @bloom-housing/backend-core@7.12.1
 - @bloom-housing/shared-helpers@7.6.1
 - @bloom-housing/partners@7.11.1
 - @bloom-housing/public@7.5.1

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* chore(release): version

 - @bloom-housing/partners@7.12.0
 - @bloom-housing/public@7.6.0

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* chore(release): version

 - @bloom-housing/backend-core@7.13.0
 - @bloom-housing/shared-helpers@7.7.0
 - @bloom-housing/partners@7.13.0
 - @bloom-housing/public@7.7.0

* fix: react type errors (bloom-housing#3382)

* chore(release): version

 - @bloom-housing/shared-helpers@7.7.1
 - @bloom-housing/partners@7.13.1
 - @bloom-housing/public@7.7.1

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* fix: remove max length from extra data app fields (bloom-housing#3394)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: type fix for token

* fix: lock file and hydration fixes

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github.context.workflow <github-actions@github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Casto <23032560+chriscasto@users.noreply.github.com>
ifranch pushed a commit to metrotranscom/doorway that referenced this pull request Apr 21, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @chriscasto
Merge Bloom Core (#47)
68ec4e9 
* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

* chore(release): version

 - @bloom-housing/partners@7.10.1

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade react to 18

* feat: upgrade cypress to 12 for public

* feat: upgrade cypress for partners

* fix: update configs

* fix: update partner cypress tests

* fix: review comments

* fix: fix flaky cypress test

* chore(release): version

 - @bloom-housing/backend-core@7.12.0
 - @bloom-housing/shared-helpers@7.6.0
 - @bloom-housing/partners@7.11.0
 - @bloom-housing/public@7.5.0

* fix: program/preference keys length uncap (bloom-housing#3376)

* fix: program/preference keys length uncap

* fix: updates per pr comments

* chore(release): version

 - @bloom-housing/backend-core@7.12.1
 - @bloom-housing/shared-helpers@7.6.1
 - @bloom-housing/partners@7.11.1
 - @bloom-housing/public@7.5.1

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* chore(release): version

 - @bloom-housing/partners@7.12.0
 - @bloom-housing/public@7.6.0

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* chore(release): version

 - @bloom-housing/backend-core@7.13.0
 - @bloom-housing/shared-helpers@7.7.0
 - @bloom-housing/partners@7.13.0
 - @bloom-housing/public@7.7.0

* fix: react type errors (bloom-housing#3382)

* chore(release): version

 - @bloom-housing/shared-helpers@7.7.1
 - @bloom-housing/partners@7.13.1
 - @bloom-housing/public@7.7.1

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* fix: remove max length from extra data app fields (bloom-housing#3394)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: type fix for token

* fix: lock file and hydration fixes

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github.context.workflow <github-actions@github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Casto <23032560+chriscasto@users.noreply.github.com>
ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request May 2, 2023
@YazeedLoonat @ludtkemorgan
fix: updates around cookies (bloom-housing#3405)
b58f8cf 
* fix: updates around cookies

* fix: creating new migration for token -> code
@ludtkemorgan ludtkemorgan mentioned this pull request May 5, 2023
Merged
ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request May 9, 2023
@YazeedLoonat @ludtkemorgan
fix: updates around cookies (bloom-housing#3405)
a3acac4 
* fix: updates around cookies

* fix: creating new migration for token -> code
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request May 18, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @seanmalbert @ColinBuyck
feat: release 2023-05-02 (#612)
504d260 
* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358)

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* fix: react type errors (bloom-housing#3382)

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

* fix: Searching on the applications table causes the page to crash (bloom-housing#3408)

* fix: pass proper value to to_tsquery function

* fix: search applications using ILIKE

* fix: change where to orWhere

* feat: add application search by confirmation code

* updates proxy to support access control allow list (bloom-housing#3407)

* feat: updates proxy to support access control allow list

* fix: remove downstream access-control-allow-origin

* fix: update readme for m1

* fix: move purge call to the backend

* fix: test fix and add await

* fix: moving cache purge to helper

---------

Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com>
Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>

* fix: escape quote in translation update

* fix: add translation for 64 characters error (bloom-housing#3423)

* fix: downgrade version of nest axios (bloom-housing#3419)

* fix: now removes criteria file if a url is input (bloom-housing#3421)

* fix: remove check in test not applicable for hba

* fix: update ui-c to latest version (bloom-housing#3420)

* fix: update application test

* feat: 3291/listing export take 2 (bloom-housing#3424)

* fix: functional frontend

* fix: hooks and service updates

* fix: hitting service file

* fix: wip config work

* fix: wip config 2

* fix: completed query updates

* fix: complete column naming and basic formatting

* fix: clean up formatting

* fix: wip testing debugging

* fix: functional unit tests

* fix: cypress tests + formatting

* fix: unadded test changes

* fix: internal csv testing

* fix: exporter test fix

* fix: more detailed csv checks

* fix: testing + formatting tweaks

* fix: exporter testing improvements

* fix: updates per pr feedback

* fix: match config pattern

* fix: add close status option

* fix: reset netlify testing

* fix: final cleanup

* fix: rent type formatting

* fix: remove console log

* fix: missing state data (bloom-housing#3450)

* feat: adding knownError flag

* feat: adding knownError flag

* fix: partners highlight field on backend error (bloom-housing#3448)

* fix: partners highlight field on backend error

* fix: community type and disableUnitsAccordion fix

* fix: unit type fix for partial units

* fix: review comment addressed

* fix: phone number fix

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

@emilyjablonski emilyjablonski emilyjablonski approved these changes

@ColinBuyck ColinBuyck Awaiting requested review from ColinBuyck

Assignees

@ludtkemorgan ludtkemorgan

@ColinBuyck ColinBuyck

@emilyjablonski emilyjablonski

Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YazeedLoonat @ludtkemorgan @emilyjablonski @ColinBuyck