Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monthly rent filter #760

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: monthly rent filter #760

merged 1 commit into from
Jul 24, 2024

Conversation

mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Jul 24, 2024

This PR addresses #(744)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Units can be created with decimals in the monthly rent field. The existing monthly rent filters on the public landing page and listings page rely on filter code that was attempting to cast these values as integers, causing an error. By casting them as floats, the filtering is working again.

How Can This Be Tested/Reviewed?

Run yarn setup in the api dir to add units with floats in the monthlyRent field. Run the application. Test the Max Monthly Rent filter on the landing page and the Min/Max Rent filters on the listings page.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jul 24, 2024
@mcgarrye mcgarrye merged commit 62c5c68 into main Jul 24, 2024
16 checks passed
@mcgarrye mcgarrye deleted the 744/monthly-rent-filter branch July 24, 2024 16:10
@mcgarrye mcgarrye removed the ready to merge Should be applied when a PR has been reviewed and approved label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants