Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monthly rent seed data #766

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

mcgarrye
Copy link
Collaborator

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Seed data bug was introduced in #760. toPercision makes a string with e+ which causes a problem in the partners portal. Switching to toFixed instead to limit decimals but not introducing other string characters.

How Can This Be Tested/Reviewed?

Run yarn setup. Check units table in the db or run partners portal and check the seeded listing units.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye added the bug Something isn't working label Jul 25, 2024
@jaredcwhite jaredcwhite self-requested a review July 25, 2024 22:18
Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jaredcwhite jaredcwhite added the ready to merge Should be applied when a PR has been reviewed and approved label Jul 25, 2024
@ludtkemorgan ludtkemorgan merged commit f83f9d5 into main Jul 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants