Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hypot() everywhere #140

Closed
meyfa opened this issue Feb 20, 2022 · 0 comments · Fixed by #176
Closed

Use hypot() everywhere #140

meyfa opened this issue Feb 20, 2022 · 0 comments · Fixed by #176
Labels
good first issue Good for newcomers

Comments

@meyfa
Copy link
Owner

meyfa commented Feb 20, 2022

Currently the hypothenuse is often computed by hand via sqrt(a*a + b*b). This can be simplified to hypot(a, b).
@meyfa meyfa added the good first issue Good for newcomers label Feb 20, 2022
@Niellles Niellles mentioned this issue Oct 23, 2022
Merged
meyfa pushed a commit that referenced this issue Oct 23, 2022
@Niellles
refactor: Use hypot() to calculate hypotenuse (#176)
544f887 
Formerly sqrt(x*x, y*y) was used. This has been replaced with PHP's native function hypot().
Fixes #140.
@Niellles Niellles mentioned this issue Oct 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Use hypot() to calculate hypotenuse
1 participant
@meyfa