ci: Migrate to PHP-CS-Fixer

[smnandre]

#229

✅ get rid of PHP-CS
✅ install PHP-CS-Fixer instead
✅ make sure PHP-CS-Fixer runs in GitHub Actions
✅ keep code changes minimal (avoid reformatting as much as possible) - this means ensuring that the PHP-CS-Fixer configuration matches our PHP-CS configuration closely)

✅ PSR-12 standard
✅ NO yoda condition

In the following steps we will see for these ones, but i guess we already have a significative change in hands with this small PR :)

• preventing backtick syntax
• enforcing long open tag (<?php)
• enforcing usage of primary functions / preventing usage of function aliases (e.g. count() vs sizeof())

Have a good day :)

[meyfa]

Amazing, great stuff!

It seems rector.php is causing an error, but the error isn't shown in the logs - do you know what this is about?

[smnandre]

I need to take a look i had none locally (but in 8.3)

[smnandre]

That's it

    ->withPhpSets(php74: true)

Named arguments are not supported before 8.0. Let's exclude this file for now :)

[meyfa]

LGTM

[smnandre]

That's still red :( Did not have time to find a fix

[meyfa]

I think we can get rid of the parameter in rector.php and it will determine it based on composer.json. That way, PHP 8 syntax is gone and CI can pass.

[smnandre]

I think we can get rid of the parameter in rector.php and it will determine it based on composer.json. That way, PHP 8 syntax is gone and CI can pass.

That'd be perfect, nice!

[smnandre]

oh sorry... @meyfa ! Iade the first step on PR... next time every commuit 😅

[meyfa]

Don't worry about it. This repo is configured to always squash commits on merge.

Thanks for another great contribution!

[smnandre]

Happy to help :)