-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove composer.lock
so that projects download latest component versions
#56
Conversation
Why don't we remove the composer.lock file entirely? It should always run against the latest supported versions. We can add it to .gitignore and remove it from .gitignore when the project is created. Just another idea... why don't we use the cronjob option in actions to check daily if it builds. |
Being an application, |
Usually I would agree, in this case I think it makes more sense to run a daily cron action then having a lockfile. By running daily tests, you know very fast that the installer broke. You could even see in the action logs why, where and when it fails. Testing against the lockfile doesn't say much in this case because the latest dependencies are always used, within the given constrains. |
If we start as of now, I would also reduce the PHP version to exactly the latest stable version. There are always older versions which are installable with older PHP versions. Thoughts? Then I would be also fine with having a |
…nent versions Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
7b455d6
to
6340be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this shouldn't be done here.
We have tooling that upgrades the lock file daily, making sure that the latest & greatest works fine.
With this change when composer.lock is deleted during install? Does it solve inability to create project on php version incompatible with the lock file? |
I've been using PHP 8.1.25 a bit, lately, and this is consistently an issue. |
Description
Since
composer.lock
is not part of the.gitignore
anymore, we can change that replacement and instead, removing thecomposer.lock
at all to prevent users from having conflicts.The
composer.lock
is used by this component for CI pipeline and thus should be removed while creating a new project.Fixes #46