Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues with SWIG4.2 #208

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Address issues with SWIG4.2 #208

merged 3 commits into from
Feb 15, 2024

Conversation

sshiraiwa
Copy link
Member

@sshiraiwa sshiraiwa commented Feb 2, 2024 •
edited
Loading

This PR address some minor changes in auto-generated wrapper codes, which causing build failure

  • two constructers in liniteg have different argument sequences.
  • can't build with external mfem #205
  • Set CMAKE_MACOS_SYSROOT using -isysroot found in sysconfig.get_config_vars()['CFLAGS']. This addresses dylib version warning and warning regarding macros in header files.

@sshiraiwa sshiraiwa self-assigned this Feb 2, 2024
@sshiraiwa sshiraiwa added In-progress build in-test-with-mfem-master trigger a workflow to test using MFEM master labels Feb 2, 2024
@sshiraiwa sshiraiwa mentioned this pull request Feb 2, 2024
Closed
@sshiraiwa sshiraiwa added in-test-with-mfem-master trigger a workflow to test using MFEM master in-test-with-mfem-release trigger a workflow to test using MFEM release and removed in-test-with-mfem-master trigger a workflow to test using MFEM master labels Feb 5, 2024
@bclyons12 bclyons12 mentioned this pull request Feb 5, 2024
Closed
@sshiraiwa
changed MFEM build by setup.py in OSX to use the same -isysroot optio…
598a566 
…n with Python itself. This avoids build warning/errores due to inconsistent use of Development Framework between MFEM/PyMFEM (I still see some warning wtih Metis)
@sshiraiwa sshiraiwa added in-test-with-mfem-master trigger a workflow to test using MFEM master in-test-with-mfem-release trigger a workflow to test using MFEM release and removed in-test-with-mfem-release trigger a workflow to test using MFEM release in-test-with-mfem-master trigger a workflow to test using MFEM master labels Feb 7, 2024
@sshiraiwa
Copy link
Member Author

@psocratis, can you try building this version under your Ventura (or Sonoma?) environment, in order to see if this fixes the error relating to header files and C++ macros?

@psocratis
Copy link
Member

@psocratis, can you try building this version under your Ventura (or Sonoma?) environment, in order to see if this fixes the error relating to header files and C++ macros?

Hi @sshiraiwa, I tested this on Sonoma and didn't have any issues. Thanks!

@sshiraiwa sshiraiwa merged commit c318aa6 into master Feb 15, 2024
26 checks passed
@bclyons12 bclyons12 mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psocratis psocratis psocratis approved these changes

Assignees

@sshiraiwa sshiraiwa

Labels
build In-progress in-test-with-mfem-release trigger a workflow to test using MFEM release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshiraiwa @psocratis