-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some incorrect statements in the mesh format description #174
Conversation
@sethwatts, I invited you to the Contributors MFEM team, so you should be able to commit to this repo (the sources for the MFEM website) if you want to edit this PR directly. The Contributors team also gives you access to the main MFEM source repo, if you want to contribute there. Let me know if you have any other recommendations for changes or additions. |
This PR addresses the issues I raised in mfem/mfem#3094, and am happy with the PR in its current state. As future work, do you think a more illustrative example than the 2D beam, say in 3D, and/or higher order and/or featuring different element geometries, would be a worthwhile contribution? I don't know how many people are writing meshes in MFEM format as compared with Cubit, VTK, etc. so it may not be worth the effort. If you see value in it, I can work on an example and open a PR on it. |
Is this ready for review? |
I believe so. |
Should a link to this page be added to the mesh formats page? I had trouble finding it on the website. |
It is linked already by the second link in the second bullet under "MFEM Mesh Formats", however, I also had trouble finding it, so I agree we need to make it more obvious, e.g. as a separate bullet for that page. |
This PR is meant to address the issue mfem/mfem#3094.