Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some incorrect statements in the mesh format description #174

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

v-dobrev
Copy link
Member

@v-dobrev v-dobrev commented Jul 1, 2022

This PR is meant to address the issue mfem/mfem#3094.

@v-dobrev v-dobrev added the WIP Work in Progress label Jul 1, 2022
@v-dobrev
Copy link
Member Author

v-dobrev commented Jul 1, 2022

@sethwatts, I invited you to the Contributors MFEM team, so you should be able to commit to this repo (the sources for the MFEM website) if you want to edit this PR directly. The Contributors team also gives you access to the main MFEM source repo, if you want to contribute there.

Let me know if you have any other recommendations for changes or additions.

@sethwatts
Copy link
Contributor

sethwatts commented Jul 1, 2022

This PR addresses the issues I raised in mfem/mfem#3094, and am happy with the PR in its current state.

As future work, do you think a more illustrative example than the 2D beam, say in 3D, and/or higher order and/or featuring different element geometries, would be a worthwhile contribution? I don't know how many people are writing meshes in MFEM format as compared with Cubit, VTK, etc. so it may not be worth the effort. If you see value in it, I can work on an example and open a PR on it.

@tzanio
Copy link
Member

tzanio commented Jul 10, 2022

Is this ready for review?

@sethwatts
Copy link
Contributor

Is this ready for review?

I believe so.

@pazner pazner added ready-for-review and removed WIP Work in Progress labels Jul 12, 2022
@pazner pazner marked this pull request as ready for review July 12, 2022 18:25
@pazner pazner requested review from pazner and tzanio July 12, 2022 18:28
@pazner
Copy link
Member

pazner commented Jul 28, 2022

Should a link to this page be added to the mesh formats page? I had trouble finding it on the website.

@v-dobrev
Copy link
Member Author

Should a link to this page be added to the mesh formats page? I had trouble finding it on the website.

It is linked already by the second link in the second bullet under "MFEM Mesh Formats", however, I also had trouble finding it, so I agree we need to make it more obvious, e.g. as a separate bullet for that page.

@tzanio tzanio merged commit 7ef9133 into master Aug 2, 2022
@tzanio tzanio deleted the fix-mesh-format-description branch August 2, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants