Skip to content

Conversation

windht
Copy link
Contributor

@windht windht commented Oct 31, 2019

In some case we may want to configure the path of socket io. That should also be included as a prop option.

@mfrachet
Copy link
Owner

What do you think of passing the full opts object available while using the io socket client? This way, we don't have to create and customize the provider customer each time? 😊

like:

this.socket = io(props.url, props.opts || {});

Thank you for the PR 😄

@windht
Copy link
Contributor Author

windht commented Nov 28, 2019

Indeed! Updated accordingly.

@mfrachet
Copy link
Owner

mfrachet commented Dec 2, 2019

Thank you so much for the PR 👍

@mfrachet mfrachet merged commit efa4a96 into mfrachet:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants