Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSG channels not fading correctly #3164

Closed
brokenps2 opened this issue Mar 11, 2024 · 5 comments
Closed

PSG channels not fading correctly #3164

brokenps2 opened this issue Mar 11, 2024 · 5 comments

Comments

@brokenps2
Copy link

When playing Super Mario Advance 4, I noticed that the PSG channels seem to not fade out and just continue playing at full volume as long as their duration is set for.

I'm using arch linux 6.7.6 & mGBA 0.10.3 SDL version.

@endrift
Copy link
Member

endrift commented Mar 11, 2024

Are there any tracks you can point to for comparison against, say, Game Boy Player footage? This is kind of vague.

@brokenps2
Copy link
Author

Yeah, it was most noticeable in the Mario Bros minigame, especially the coin falling sound (after enemy is killed)

This is what it sounds like for me
This is a longplay of the the minigame, you can hear it at 0:43

@endrift
Copy link
Member

endrift commented Mar 18, 2024

Wow, That's definitely not happening for me in dev. Let me check 0.10.3.

@endrift
Copy link
Member

endrift commented Mar 18, 2024

Scratch that, it does happen in 0.10.3...in Super Mario Advance 4. I was trying a different version of the Mario Bros. minigame where it doesn't happen (in Mario & Luigi). I also confirmed that it works as expected on original hardware.

@endrift
Copy link
Member

endrift commented Mar 18, 2024

Regression from c8f4d4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants