Skip to content

PSG channels not fading correctly #3164

Description

@elithom09

When playing Super Mario Advance 4, I noticed that the PSG channels seem to not fade out and just continue playing at full volume as long as their duration is set for.

I'm using arch linux 6.7.6 & mGBA 0.10.3 SDL version.

Activity

  1. endrift commented on Mar 11, 2024

    @endrift
    Member

    Are there any tracks you can point to for comparison against, say, Game Boy Player footage? This is kind of vague.

  2. elithom09 commented on Mar 12, 2024

    @elithom09
    Author

    Yeah, it was most noticeable in the Mario Bros minigame, especially the coin falling sound (after enemy is killed)

    This is what it sounds like for me
    This is a longplay of the the minigame, you can hear it at 0:43

  3. endrift commented on Mar 18, 2024

    @endrift
    Member

    Wow, That's definitely not happening for me in dev. Let me check 0.10.3.

  4. endrift commented on Mar 18, 2024

    @endrift
    Member

    Scratch that, it does happen in 0.10.3...in Super Mario Advance 4. I was trying a different version of the Mario Bros. minigame where it doesn't happen (in Mario & Luigi). I also confirmed that it works as expected on original hardware.

  5. endrift commented on Mar 18, 2024

    @endrift
    Member

    Regression from c8f4d4a

  6. added a commit that references this issue on Mar 18, 2024
    557a3b6
  7. added a commit that references this issue on Mar 18, 2024
    4fdadc5
  8. added a commit that references this issue on Sep 9, 2026
    3c0731d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions