-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSG channels not fading correctly #3164
Comments
Are there any tracks you can point to for comparison against, say, Game Boy Player footage? This is kind of vague. |
Yeah, it was most noticeable in the Mario Bros minigame, especially the coin falling sound (after enemy is killed) This is what it sounds like for me |
Wow, That's definitely not happening for me in dev. Let me check 0.10.3. |
Scratch that, it does happen in 0.10.3...in Super Mario Advance 4. I was trying a different version of the Mario Bros. minigame where it doesn't happen (in Mario & Luigi). I also confirmed that it works as expected on original hardware. |
Regression from c8f4d4a |
When playing Super Mario Advance 4, I noticed that the PSG channels seem to not fade out and just continue playing at full volume as long as their duration is set for.
I'm using arch linux 6.7.6 & mGBA 0.10.3 SDL version.
The text was updated successfully, but these errors were encountered: