Remove $scope service in favor of use the "Controller as" syntax in the examples #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and 'vm' alias instead of using $scope service. Using single quotes into some javascript examples.
|
Good point, thanks! I'll review the PR tomorrow and merge. |
|
Hi @mgechev are you good with these changes? |
mgechev
added a commit
that referenced
this pull request
Mar 14, 2016
Remove $scope service in favor of use the "Controller as" syntax in the examples
|
Yes, sorry for the delay. Looks great! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated some templates and JavaScript code in order to use "Controller as" syntax and an alias instead of use
$scopeservice which is suggested as a best practice for AngularJS.Also, I updated some scripts with the use of single quotes instead of double quotes.