fix issue 556 (#557)

mgechev · Aug 16, 2021 · 2855950 · 2855950
1 parent c582d62
commit 2855950
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/rule/useless-break.go b/rule/useless-break.go
@@ -41,6 +41,11 @@ func (w *lintUselessBreak) Visit(node ast.Node) ast.Visitor {
 		ast.Walk(w, v.Body)
 		w.inLoopBody = false
 		return nil
+	case *ast.RangeStmt:
+		w.inLoopBody = true
+		ast.Walk(w, v.Body)
+		w.inLoopBody = false
+		return nil
 	case *ast.CommClause:
 		for _, n := range v.Body {
 			w.inspectCaseStatement(n)

diff --git a/testdata/useless-break.go b/testdata/useless-break.go
@@ -1,6 +1,9 @@
 package fixtures
 
-import "reflect"
+import (
+	ast "go/ast"
+	"reflect"
+)
 
 func UselessBreaks() {
 
@@ -28,7 +31,7 @@ func UselessBreaks() {
 	for {
 		switch {
 		case c1:
-			break // MATCH /useless break in case clause (WARN: this break statement affects the switch or select statement and not the loop enclosing it)/
+			break // MATCH /useless break in case clause (WARN: this break statement affects this switch or select statement and not the loop enclosing it)/
 		}
 	}
 
@@ -37,7 +40,7 @@ func UselessBreaks() {
 		case *ast.FuncLit:
 			found = true
 			funcLit = node
-			break // MATCH /useless break in case clause (WARN: this break statement affects the switch or select statement and not the loop enclosing it)/
+			break // MATCH /useless break in case clause (WARN: this break statement affects this switch or select statement and not the loop enclosing it)/
 		}
 	}