Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banned characters #532

Closed
SamuelCabralCruz opened this issue Jun 17, 2021 · 5 comments · Fixed by #591
Closed

Banned characters #532

SamuelCabralCruz opened this issue Jun 17, 2021 · 5 comments · Fixed by #591
Assignees
Labels

Comments

@SamuelCabralCruz
Copy link

SamuelCabralCruz commented Jun 17, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I want to prevent the use of Ω symbol in projects using Gomega.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Without creating rules specific to gomega, it would be nice to have a rule to prevent a given list of symbols.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

At the moment, I am thinking about creating a manual check in my makefile to be run at lint step.

.PHONY: lint
lint:
    @grep "Ω" **/*.go; if [ "$$?" = "0" ]; then exit 1; fi
    [...]

Additional context
Add any other context or screenshots about the feature request here.

This should not be allowed.
image

@chavacava chavacava added help wanted rule proposal Issue proposing a new rule labels Jun 19, 2021
@doniacld
Copy link
Contributor

Hey!
I would be interested to work on this issue. If you could assign it to me please ?

doniacld added a commit to doniacld/revive that referenced this issue Oct 12, 2021
doniacld added a commit to doniacld/revive that referenced this issue Oct 13, 2021
doniacld added a commit to doniacld/revive that referenced this issue Oct 13, 2021
doniacld added a commit to doniacld/revive that referenced this issue Oct 13, 2021
@SamuelCabralCruz
Copy link
Author

SamuelCabralCruz commented Nov 28, 2021

@doniacld Thanks a lot for your time!

However, I just tried it out using example config provided in the documentation and I am getting cannot find rule: banned-characters error.
I went through the code and everything seems fine.
I am really clueless about what could cause this error.
I am using latest version of revive.
Is this rule supposed to be release or not yet @mgechev ?

Thanks again!

@SamuelCabralCruz
Copy link
Author

Just found my answer:
Last release was in September and this pull request has been merged in October. Sorry for the disruption.
When are you expecting to make another release?

@SamuelCabralCruz
Copy link
Author

@mgechev any insights about above question?

@mgechev
Copy link
Owner

mgechev commented Jan 20, 2022

I pushed a new tag yesterday, but it seems the GitHub workflow failed. I'll look into this later today/over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants