Rule to spot (possibly) inefficient conditional expressions

[chavacava]

In some cases it is possible to alter the order of terms in a conditional expression to speed up its average evaluation time.
For example:

if isGenerated(content) && !config.IgnoreGeneratedHeader {

can be safely (i.e. no change in the semantic) rewritten as

if !config.IgnoreGeneratedHeader && isGenerated(content) {

To avoid making a function call in those cases where !config.IgnoreGeneratedHeader evaluates to false

A rule like this can not have a confidence of 1 because the analysis does not have enough context information to know whether altering the order of terms is semantically safe (for example, when the function is not pure).

[doniacld]

Hola @chavacava
I would be happy to add this new rule, if you could assign me the issue ?
Thanks