overwrite error status code from config with set_exit_status #589
Conversation
jan-xyz
changed the title
main.go
Outdated
| @@ -36,6 +36,10 @@ func main() { | |||
| if err != nil { | |||
| fail(err.Error()) | |||
| } | |||
| if setExitStatus { | |||
| conf.ErrorCode = 1 | |||
| conf.WarningCode = 2 | |||
There was a problem hiding this comment.
I think we should not change the error code for warning otherwise running
revive -set_exit_status
will return 2 in presence of failures (because the default severity is warning)
while
golint -set_exit_status
will return 1
I think we could set the error code for warnings to 1 or set the default severity to error (I prefer the first)
There was a problem hiding this comment.
Ahh yeah, I set the warning code as well, because otherwise it won't trigger with just that flag. I like your idea to afterwards then also patch the default severity! I'll get right into it.
There was a problem hiding this comment.
I changed it accordingly 😊 please have another look
|
Hi @jan-xyz, thanks for the PR, I've left a couple of comments |
|
thanks @jan-xyz ! |
|
No worries! I noticed you went in the end with seeing both codes to 1, did I misunderstand you on the weekend, or did you change your mind? Would love to better understand what I could've done better, if you don't mind sharing 😊 |
|
Hi @jan-xyz, sorry for the late response.
In my (original) comment I suggested to set the default severity to warning, and just few seconds after commenting I've modified the comment to add the alternative of setting to 1 the error code for warnings. I think you read the first version of my comment. Sorry for that, my bad.
Thanks again |
This PR is a result from a discussion in an already closed issue. It copies the functionality from golang/lint to set only the error exit code to 1 and leave everything else untouched.
I didn't add tests for this change, but I can do so, if you point me in a good place to add it.
relates to #241