Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids missing version description when using go install #600

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

jefersonf
Copy link
Contributor

As an addition to #593, I have added a second form of version description to avoid missing when using go install.

The go install command is not able to retrieve the flags (commit, date and builtBy) unless they are explicitly stated in the release code. But we can get the version, which can be useful when is requested for the latest version.

Closes #560

@chavacava chavacava merged commit b7d1908 into mgechev:master Oct 17, 2021
@chavacava
Copy link
Collaborator

Hi @jefersonf thanks for the PR

@jefersonf jefersonf deleted the 560-work-around-fix branch November 2, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambigous version information printed when installing with 'go install'
2 participants