add support for relative imports #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to the number of preceding dots on a "from ..xyz import qpr" relative import statement.
|
Awesome, thanks! |
| """Given a fully qualified name, find what module contains it.""" | ||
| if dotted_name.endswith('.*'): | ||
| return dotted_name[:-2] | ||
| name = dotted_name | ||
|
|
||
| orig_extrapath = extrapath |
There was a problem hiding this comment.
You're introducing a new local variable here, but it doesn't seem to be used anywhere...
There was a problem hiding this comment.
yeah that's a goof, you can take that out...
mgedmin
added a commit
that referenced
this pull request
Aug 5, 2013
add support for relative imports (from . import X)
|
Looks good, merged, thanks again! |
|
Bikeshedding: is this a feature ("add support for relative import syntax introduced in Python 2.somethingprettyoldbynow") or a bugfix ("findimports didn't understand relative import syntax introduced in Python 2.somethingprettyoldbynow")? Because if it's a feature, then I ought to bump the version number to 1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per pep 328, relative imports add the ability to alter an import based on a "level" counter, which syntactically is a number of dots. With these changes I've managed to produce successful graphs for parts of SQLAlchemy (which uses all relative imports) without any errors. I've updated the tests though there should probably be some tests that test specifically the path resolution against the "sample-tree" package.