Skip to content

Allow \Drupal calls in traits and tests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Allow \Drupal calls in traits and tests #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public function processNode(Node $node, Scope $scope): array
if (!($node->class instanceof Node\Name\FullyQualified) || (string) $node->class !== 'Drupal') {
return [];
}
if (!$scope->isInClass() && !$scope->isInTrait()) {
// Do not raise if called inside of a trait.
if (!$scope->isInClass() || $scope->isInTrait()) {
return [];
}
$scopeClassReflection = $scope->getClassReflection();
Expand All @@ -32,6 +33,8 @@ public function processNode(Node $node, Scope $scope): array
}

$whitelist = [
// Ignore tests.
'PHPUnit\Framework\TestCase',
// Typed data objects cannot use dependency injection.
'Drupal\Core\TypedData\TypedDataInterface',
// Render elements cannot use dependency injection.
Expand Down