Skip to content

Refactor to atomic transforms + data sources #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2020
Merged

Refactor to atomic transforms + data sources #34

merged 6 commits into from
Nov 7, 2020

Conversation

mheap
Copy link
Owner

@mheap mheap commented Sep 16, 2020

This refactor adds the following:

  • Unit tests to be written for all of the transforms
  • Allows all transforms to be skipped
  • Switch to the debug module for logging
  • Replacements may now use an async function to fetch data before returning the required replacements

Known gaps:

  • Octokit enterprise functionality unit tests
  • updateContent tests

There are BREAKING CHANGES to the CLI interface, and so this must be released as a v2.

@mheap mheap merged commit 48b6357 into main Nov 7, 2020
@mheap mheap deleted the rebuild branch November 7, 2020 20:35
@mheap mheap mentioned this pull request Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant