Add option to modify the secure attribute #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove once it has been confirmed
and remove once it has been confirmed
* Plus, add badges to README
* jQuery ~ upgrade version 2.1.4 to 3.3.1; * QUnit Javascript ~ 1.18.0 to 2.6.1;
Add Travis-CI automated tests
* Also move QUnit from peer to `devDependencies` * #1
Follow-up to pull #1 - move jQuery to `devDependencies` for clarity
* Plus, switch npm badge to ~ https://badge.fury.io/
Add support for `data-cookie-attribute`
* Add `files`, bugs, engines & contributors fields to package JSON; * Remove Nick's email address from README & bower JSON; * Validator ~ http://package-json-validator.com/
* Automated accessibility testing via ~ http://pa11y.org/
* ... plus - link target, link underline
* ... in the Grunt Javascript * Plus, add `live-server` to `peerDependencies` package JSON
Add accessibility testing and fixes
|
Hello @JEric49, I guess you were looking to open the PR on https://github.com/AOEpeople/cookie-notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm receiving this warning message in Firefox 'Cookie “cookie_notice” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute.'