Fix double click bug #109

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@richardcpeterson

Before, when the user would click an item twice before the
item finished animating, two click events would be fired,
causing extra elements to be added to the other list. To
reproduce this bug, set animation to "slow", and double
click an item.

Now, we use the jQuery "one" function to register the
click handlers, ensuring that events only fire once per
element. Since the elements are discarded and not reused,
this doesn't present any problems, and fixes the bug.

Fix double click bug
Before, when the user would click an item twice before the
item finished animating, two click events would be fired,
causing extra elements to be added to the other list. To
reproduce this bug, set animation to "slow", and double
click an item.

Now, we use the jQuery "one" function to register the
click handlers, ensuring that events only fire once per
element. Since the elements are discarded and not reused,
this doesn't present any problems, and fixes the bug.
@NateEag

This comment has been minimized.

Show comment Hide comment
@NateEag

NateEag Dec 17, 2011

Hey Richard,

crdeutsch is maintaining a fork of this that has a number of fixes applied, including a fix I did a while back for this bug. He's doing a good job of staying on top of pull requests thus far.

You might want to try his fork out:

https://github.com/crdeutsch/multiselect/

NateEag commented Dec 17, 2011

Hey Richard,

crdeutsch is maintaining a fork of this that has a number of fixes applied, including a fix I did a while back for this bug. He's doing a good job of staying on top of pull requests thus far.

You might want to try his fork out:

https://github.com/crdeutsch/multiselect/

@richardcpeterson

This comment has been minimized.

Show comment Hide comment
@richardcpeterson

richardcpeterson Dec 17, 2011

Thanks! I ended up finding his fork. Thanks for your work starting
this. I'm using it to assign permissions to users in a military
transport management system. It works great.

Thank you,

Richard

On Dec 16, 2011, at 19:55, Nate Eagleson
reply@reply.github.com
wrote:

Hey Richard,

crdeutsch is maintaining a fork of this that has a number of fixes applied, including a fix I did a while back for this bug. He's doing a good job of staying on top of pull requests thus far.

You might want to try his fork out:

https://github.com/crdeutsch/multiselect/


Reply to this email directly or view it on GitHub:
#109 (comment)

Thanks! I ended up finding his fork. Thanks for your work starting
this. I'm using it to assign permissions to users in a military
transport management system. It works great.

Thank you,

Richard

On Dec 16, 2011, at 19:55, Nate Eagleson
reply@reply.github.com
wrote:

Hey Richard,

crdeutsch is maintaining a fork of this that has a number of fixes applied, including a fix I did a while back for this bug. He's doing a good job of staying on top of pull requests thus far.

You might want to try his fork out:

https://github.com/crdeutsch/multiselect/


Reply to this email directly or view it on GitHub:
#109 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment