bug: Initial use of the package

[neznaika0]

Thanks, @michalsn, for the chance to test 😄

There are shortcomings at the initial stage:

• By default, SQLite3 in memory is used in the local test. Since there are typing differences between mariadb, the numeric types for Entity are not a string (for example, user.id ). The tests fail '1' !== 1.
• I tried to set up the connection via .env - it doesn't work. I need to use phpunit.xml.dist.
• After setting up the connection, another difference in packages is that my mariadb 12 returns the error SQL Error [1062] [23000]: (conn=16) Duplicate entry 'Test User 1' for key 'username' and Tests\ModelTest::testDatabaseErrorsOnUpdate fails.
• Does not apply to the code: The creation of a issue on Github is indicated on the Feauters Request.

Solution:

• We can use DataCaster for an Entity to get the same types or compare it with a type conversion (int) $id.
• I haven't figured out yet why env is not relevant.
• You can add a Regexp check or shorten the phrase to a column.

Do you have any suggestions or is it insignificant?
I will continue the review. Maybe I'll find something.

[neznaika0]

I suppose entities are not fully supported? I tried to call $postModel->with('user')->findAll(5), but it can't convert the condition to whereIn() because it's an Entity.

class PostModel extends AbstractModel
{
    use HasRelations;

    protected $table         = 'post';
    protected $returnType    = Post::class;
    protected $allowedFields = [
        'user_id',
        'name',
        'slug',
        'article',
        'reading_time',
        'created_at',
    ];
    protected array $casts = [
        'id'           => '?int',
        'user_id'      => 'int',
        'reading_time' => 'int',
        'created_at'   => 'datetime',
    ];

    protected function initialize()
    {
        $this->initRelations();
    }

    public function user(): Relation
    {
        return $this->belongsTo(UserModel::class);
    }
}

class Post extends AbstractEntity
{
    protected $datamap = [
        'createdAt'   => 'created_at',
        'readingTime' => 'reading_time',
        'userId'      => 'user_id', // Note: Attempt to read property "user_id" on array on relation process (line 406)
    ];
}

codeigniter-nested-model/src/Traits/HasRelations.php

Lines 398 to 409 in 8c6a8c4

	foreach ($this->relations as $relationName => $relationObject) {
	$ids = array_column($eventData['data'], $relationObject->primaryKey);
	$relationData = $this->getDataForRelationByIds($ids, $relationObject, $relationName);
	foreach ($eventData['data'] as &$data) {
	if ($this->tempReturnType === 'array') {
	$data[$relationName] = $relationData[$data[$relationObject->primaryKey]] ?? [];
	} else {
	$data->{$relationName} = $relationData[$data->{$relationObject->primaryKey}] ?? [];
	}
	}
	}

UPDATE: I found solution.
Replace $ids as:

// $ids          = array_column($raw, $relationObject->primaryKey);
$ids = array_map(function($row) use ($relationObject) {
    return is_array($row)
        ? $row[$relationObject->primaryKey]
        : $row->{$relationObject->primaryKey};
}, $eventData['data']);

UPDATE: I do not know where the problem is, but the error has disappeared. It seems to be about the private properties of the Entity 😕

[michalsn]

1. Use Model casting. I don't wanna apply any additional magic here. The behavior should be the same as in the framework.
2. This is expected.
3. Sorry, but I have no power over what exactly error message is returned over different databases. Thank you for sending a fix.
4. I guess I forgot to update the issue templates. Thanks for mentioning this.
5. I was able to recreate an issue with the mapping in the entity. I will send a fix.

[michalsn]

@neznaika0 Thank you.

If you notice any other issues, please feel free to report them.

I will hold off on releasing the new version until next week.

[neznaika0]

Good. I'm still testing.