Skip to content

Conversation

neznaika0
Copy link
Contributor

@neznaika0 neznaika0 commented Oct 6, 2025

Description
Optimized the list of IDs for whereIn(). Before that, the IDs were repeated: [1, 2, 1, 3, 1].
Although SQL optimizes this on its own, it looks better on the PHP side.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0 neznaika0 force-pushed the fix/improve-get-ids branch from acc68ae to 89b8a1a Compare October 6, 2025 17:48
@michalsn michalsn merged commit cf01743 into michalsn:develop Oct 6, 2025
15 checks passed
@michalsn
Copy link
Owner

michalsn commented Oct 6, 2025

Thank you.

@michalsn michalsn changed the title fix: Improve IDs for whereIn() fix: remove unnecessary imports from tests Oct 6, 2025
@neznaika0 neznaika0 deleted the fix/improve-get-ids branch October 6, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants