-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a wrapper to access to Screen, Workspacess and Monitor #770
Conversation
As a note, probably this should come with a version check on 2.30 (2.29). Or better, we could just make the code abstract to work with both versions, I'm open to that, let me know what you prefer. |
Hi Marco, sorry for the late reply and thatk you for the contribution. My understanding is that this is compatible only with the upcoming gnome-shell 3.30. I'll need to consider dropping support for older versions at a certain point, but I'd like to keep tha main branch compatible al least with the current Ubuntu LTS and possibly Debian stable (which I'm running daily). As it seems that the API haven't actualy changed but just being moved around, I would rahter make the code abstract to work with versions for now, with an explicit comment reminding to drop the upstraction in the future. At the moment we are supporting with the same codebase way back to 3.18. I would consider targetig 3.22+ if that's of any help. |
Yeah, I quite agree with that... As it wouldn't be too much complexity as instead maintaining different branches. I'll rework on that soon. |
1114df2
to
3ef8977
Compare
So, @micheleg, i've refactored the change a bit to use the It works fine here in both gnome-shell 3.28 and 3.29.4 (and git). |
3ef8977
to
c241edc
Compare
As per mutter xwayland-on-demand preparation branch refactory MetaScreen has been removed, thus replacing the dead objects. Basically global.screen moved to global.display, while all the workspace related features have been moved to the WorkspaceManager and displays are managed by DisplayManager. In order to keep the extension working in both 3.28 and 3.30 gnome-shell we need to support this change by creating wrapper functions that use the gnome.screen if that is available or the proper new object otherwise.
c241edc
to
5fd2d0a
Compare
Merged as [8398d41] with just a couple of modifications to maintain compatibility also with pre ES6 gjs versions (e.g gnome-shell 3.22). Thank you! |
As per mutter xwayland-on-demand preparation branch refactory,
MetaScreen has been removed, thus replacing the dead objects.
Basically global.screen moved to global.display, while all the
workspace related features have been moved to the WorkspaceManager
and displays are managed by DisplayManager.