Merged TOC feature from jtopjian's fork #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it is the role of Markdown (or Markdown Extra) to create an outline of your document. If you need an outline, it can and should be done by scanning the resulting HTML following the algorithm specified in the HTML5 spec. Also, auto-generating id attributes is problematic, because they must be unique. The user might have specified the same value for an id attribute elsewhere in the document, or might embed the document into something which already has an identical id attribute. Otherwise, this patch looks well done. If it works well for you that's great. But I won't merge it for the reasons stated above, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think auto-generation of table of content(TOC) is very useful. And I searched and found jtopjian's fork had done that yet. so I merge his branch to my fork.
Beside jtopjian's TOC upgrade, I also did an improvement, which one could use TOC by headers' ID not specified(the not specified ID would be replaced by the header text).