Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dev files from dist package #374

Merged
merged 1 commit into from Sep 1, 2022
Merged

Exclude dev files from dist package #374

merged 1 commit into from Sep 1, 2022

Conversation

cedric-anne
Copy link
Contributor

For the time being, when fetching the dist package from composer, all repository files are included.
Using export-ignore git attribute would permit to make the dist package ligther (see https://php.watch/articles/composer-gitattributes#export-ignore).

Ignore files weight: 195.5kB
Remaining files weight: 128.2kB

@michelf
Copy link
Owner

michelf commented Sep 1, 2022

My objection to this is it will also affect the archives you can download from GitHub.

@cedric-anne
Copy link
Contributor Author

It could also be done by adding a archive.exclude property in composer.json. Do you want me to update this PR with this solution ?

@michelf
Copy link
Owner

michelf commented Sep 1, 2022

Sounds like a good idea.

@cedric-anne
Copy link
Contributor Author

Done.

@michelf michelf merged commit fcfbf56 into michelf:lib Sep 1, 2022
@michelf
Copy link
Owner

michelf commented Sep 1, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants