Add support for pasting text for uploaded file caption #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny-hsiao
force-pushed
the
feature/paste-txt-for-file-caption
branch
from
3ad3627
to
711777b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Miguel,
We noticed that when a user paste a blurb of text for an uploaded file's caption, the conversation breaks. Upon further investigation, it appears that it is because Dante doesn't support type of "file" when pasting text. In this PR, I am adding a support for that case, as well as an example in Dante2 to show Upload file.
This screenshot shows that data becomes {} when pasting a text for file caption:
After applying the fix, the data has file info again:
File component in doc:
