Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-observers-v2] Linting changes #180

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2024

This pull request includes linting changes based on the target branch.

Please review and merge if everything looks good.

Additional suggestions: ./.vscode/settings.json:7:3 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected a property but instead found '}'.

5 │     "package.json": "README.md,.gitignore, tsconfig.json, rome.json, *.tsconfig.json, LICENSE.md, package-lock.json, jest-puppeteer.config.cjs, michi.config.ts",
6 │     "*.tsx": "$(capture).css, $(capture).css.ts, $(capture).html, $(capture).spec.ts, $(capture).spec.tsx",

7 │ }
│ ^
8 │ }
9 │

i Expected a property here.

5 │     "package.json": "README.md,.gitignore, tsconfig.json, rome.json, *.tsconfig.json, LICENSE.md, package-lock.json, jest-puppeteer.config.cjs, michi.config.ts",
6 │     "*.tsx": "$(capture).css, $(capture).css.ts, $(capture).html, $(capture).spec.ts, $(capture).spec.tsx",

7 │ }
│ ^
8 │ }
9 │

./.vscode/settings.json:7:3 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected a property but instead found '}'.

5 │     "package.json": "README.md,.gitignore, tsconfig.json, rome.json, *.tsconfig.json, LICENSE.md, package-lock.json, jest-puppeteer.config.cjs, michi.config.ts",
6 │     "*.tsx": "$(capture).css, $(capture).css.ts, $(capture).html, $(capture).spec.ts, $(capture).spec.tsx",

7 │ }
│ ^
8 │ }
9 │

i Expected a property here.

5 │     "package.json": "README.md,.gitignore, tsconfig.json, rome.json, *.tsconfig.json, LICENSE.md, package-lock.json, jest-puppeteer.config.cjs, michi.config.ts",
6 │     "*.tsx": "$(capture).css, $(capture).css.ts, $(capture).html, $(capture).spec.ts, $(capture).spec.tsx",

7 │ }
│ ^
8 │ }
9 │

./.vscode/settings.json format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Code formatting aborted due to parsing errors. To format code with errors, enable the 'formatter.formatWithErrors' option.

./dist.tsconfig.json format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Formatter would have printed the following content:

 1  1 │   {
 2    │ - ··"compilerOptions":·{
 3    │ - ····"strictFunctionTypes":·true,
 4    │ - ····"strictNullChecks":·true,
 5    │ - ····"strictBindCallApply":·true,
 6    │ - ····"resolveJsonModule":·true,
 7    │ - ····"allowJs":·true,
 8    │ - ····"allowSyntheticDefaultImports":·true,
 9    │ - ····"allowUnreachableCode":·false,
10    │ - ····"declaration":·true,
11    │ - ····"experimentalDecorators":·true,
12    │ - ····"noErrorTruncation":·true,
13    │ - ····"lib":·[
14    │ - ······"dom",
15    │ - ······"ESNext"
16    │ - ····],
17    │ - ····"outDir":·"dist",
18    │ - ····"moduleResolution":·"node",
19    │ - ····"module":·"esnext",
20    │ - ····"target":·"esnext",
21    │ - ····"noUnusedLocals":·false,
22    │ - ····"noUnusedParameters":·false,
23    │ - ····"noImplicitThis":·true,
24    │ - ····"jsx":·"react-jsx",
25    │ - ····"jsxImportSource":·"@michijs/michijs",
26    │ - ····"paths":·{
27    │ - ······"@michijs/michijs/*":·[
28    │ - ········"./src/*"
29    │ - ······],
30    │ - ······"@michijs/michijs":·[
31    │ - ········"./src/index"
32    │ - ······]
33    │ - ····}
34    │ - ··},
35    │ - ··"include":·[
36    │ - ····"src"
37    │ - ··],
38    │ - ··"exclude"·:·[
39    │ - ····"src/**/*.spec.ts",
40    │ - ····"src/**/*.spec.tsx"
41    │ - ··]
42    │ - }
    2 │ + → "compilerOptions":·{
    3 │ + → → "strictFunctionTypes":·true,
    4 │ + → → "strictNullChecks":·true,
    5 │ + → → "strictBindCallApply":·true,
    6 │ + → → "resolveJsonModule":·true,
    7 │ + → → "allowJs":·true,
    8 │ + → → "allowSyntheticDefaultImports":·true,
    9 │ + → → "allowUnreachableCode":·false,
   10 │ + → → "declaration":·true,
   11 │ + → → "experimentalDecorators":·true,
   12 │ + → → "noErrorTruncation":·true,
   13 │ + → → "lib":·["dom",·"ESNext"],
   14 │ + → → "outDir":·"dist",
   15 │ + → → "moduleResolution":·"node",
   16 │ + → → "module":·"esnext",
   17 │ + → → "target":·"esnext",
   18 │ + → → "noUnusedLocals":·false,
   19 │ + → → "noUnusedParameters":·false,
   20 │ + → → "noImplicitThis":·true,
   21 │ + → → "jsx":·"react-jsx",
   22 │ + → → "jsxImportSource":·"@michijs/michijs",
   23 │ + → → "paths":·{
   24 │ + → → → "@michijs/michijs/*":·["./src/*"],
   25 │ + → → → "@michijs/michijs":·["./src/index"]
   26 │ + → → }
   27 │ + → },
   28 │ + → "include":·["src"],
   29 │ + → "exclude":·["src/**/*.spec.ts",·"src/**/*.spec.tsx"]
   30 │ + }
   31 │ + 

./.vscode/tasks.json:12:9 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected a property but instead found '}'.

10 │                 "isDefault": true
11 │             },

12 │ },
│ ^
13 │ {
14 │ "label": "dist",

i Expected a property here.

10 │                 "isDefault": true
11 │             },

12 │ },
│ ^
13 │ {
14 │ "label": "dist",

./.vscode/tasks.json:21:9 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected a property but instead found '}'.

19 │                 "isDefault": true
20 │             },

21 │ },
│ ^
22 │ ]
23 │ }

i Expected a property here.

19 │                 "isDefault": true
20 │             },

21 │ },
│ ^
22 │ ]
23 │ }

./.vscode/tasks.json:22:5 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected an array, an object, or a literal but instead found ']'.

20 │             },
21 │         },

22 │ ]
│ ^
23 │ }

i Expected an array, an object, or a literal here.

20 │             },
21 │         },

22 │ ]
│ ^
23 │ }

./.vscode/tasks.json:12:9 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected a property but instead found '}'.

10 │                 "isDefault": true
11 │             },

12 │ },
│ ^
13 │ {
14 │ "label": "dist",

i Expected a property here.

10 │                 "isDefault": true
11 │             },

12 │ },
│ ^
13 │ {
14 │ "label": "dist",

./.vscode/tasks.json:21:9 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected a property but instead found '}'.

19 │                 "isDefault": true
20 │             },

21 │ },
│ ^
22 │ ]
23 │ }

i Expected a property here.

19 │                 "isDefault": true
20 │             },

21 │ },
│ ^
22 │ ]
23 │ }

./.vscode/tasks.json:22:5 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Expected an array, an object, or a literal but instead found ']'.

20 │             },
21 │         },

22 │ ]
│ ^
23 │ }

i Expected an array, an object, or a literal here.

20 │             },
21 │         },

22 │ ]
│ ^
23 │ }

./.vscode/tasks.json format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Code formatting aborted due to parsing errors. To format code with errors, enable the 'formatter.formatWithErrors' option.

./michi.config.ts:30:7 lint/style/noNonNullAssertion ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Forbidden non-null assertion.

28 │     };
29 │     if (environment === "TESTING") {

30 │ defaultConfig.public!.path = "./tests/benchmark/michijs/public";
│ ^^^^^^^^^^^^^^^^^^^^^
31 │ defaultConfig.esbuildOptions.entryPoints = [
32 │ "./tests/benchmark/michijs/src/index.tsx",

./michi.config.ts:35:7 lint/style/noNonNullAssertion ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Forbidden non-null assertion.

33 │       ];
34 │     } else {

35 │ defaultConfig.public!.path = "./tests/benchmark/vanillajs/public";
│ ^^^^^^^^^^^^^^^^^^^^^
36 │ defaultConfig.esbuildOptions.entryPoints = [
37 │ "./tests/benchmark/vanillajs/src/index.js",

./tests/CounterWithReduxStore.tsx:33:11 lint/a11y/useButtonType ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Provide an explicit type prop for the button element.

31 │       return (
32 │         <Host count={count}>

33 │ -
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
34 │ {count}
35 │ +

i The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.

i Allowed button types are: submit, button or reset

./tests/CounterWithReduxStore.tsx:35:11 lint/a11y/useButtonType ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Provide an explicit type prop for the button element.

33 │           <button onpointerup={decrementCount}>-</button>
34 │           <span>{count}</span>

35 │ +
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
36 │
37 │ );

i The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.

i Allowed button types are: submit, button or reset

./michi.config.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

 1  1 │   import type {
 2    │ - ··ServerConfig,
 3    │ - ··ServerConfigFactory,
 4    │ - ··DefaultEnvironment,
    2 │ + ··DefaultEnvironment,
    3 │ + ··ServerConfig,
    4 │ + ··ServerConfigFactory,
 5  5 │   } from "@michijs/dev-server";
 6  6 │   

./tests/CounterWithReduxStore.tsx organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

 1  1 │   import {
 2    │ - ··createCustomElement,
    2 │ + ··EventDispatcher,
 3  3 │     Host,
 4    │ - ··EventDispatcher,
    4 │ + ··createCustomElement,
 5  5 │     useComputedObserve,
 6  6 │   } from "@michijs/michijs";

./tests/StoredObservableCounter.tsx:30:11 lint/a11y/useButtonType ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Provide an explicit type prop for the button element.

28 │       return (
29 │         <Host count={count}>

30 │ -
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
31 │ {count}
32 │ +

i The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.

i Allowed button types are: submit, button or reset

./tests/StoredObservableCounter.tsx:32:11 lint/a11y/useButtonType ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Provide an explicit type prop for the button element.

30 │           <button onpointerup={decrementCount}>-</button>
31 │           <span>{count}</span>

32 │ +
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
33 │
34 │ );

i The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.

i Allowed button types are: submit, button or reset

./tests/StoredObservableCounter.tsx organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

 1  1 │   import {
 2    │ - ··Host,
 3    │ - ··useStorage,
 4    │ - ··EventDispatcher,
 5    │ - ··customElement,
    2 │ + ··EventDispatcher,
    3 │ + ··Host,
    4 │ + ··customElement,
    5 │ + ··useStorage,
 6  6 │   } from "@michijs/michijs";
 7  7 │   import { counterStyle } from "./shared/counterStyle";

The number of diagnostics exceeds the number allowed by Biome.
Diagnostics not shown: 793.
Checked 206 files in 320ms. No fixes needed.
Found 837 errors.
check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Some errors were emitted while running checks.

@github-actions github-actions bot closed this Mar 8, 2024
@github-actions github-actions bot deleted the new-observers-v2_lint branch March 8, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants