Exercise updates #504
Exercise updates #504
Conversation
|
really helpful, thanks! |
|
I changed the interpretation, removed agglomeration and ajusted the p-values issue. Please let me know if there's anything else i should change. |
|
Can you resolve the comments that have been addressed? It will make it easier to track progress. |
|
Hi! Thanks for improving the exercises! I added another suggestion in the related issue: #359 (comment) |
|
I adjusted the existing heatmap exercise and created a new one using the complexHeatmap package. For the first heatmap, I subsetted the heatmap to use the top taxa and samples by their relative abundance so the heatmap remains readable. |
|
I updated the heatmap to use sechm and simplified the subsetting. I'll take a look at the batch transformations now. |
|
is there a gap in documentation? |
|
The documentation seems to use some deprecated functions in some chapters making it difficult to know which parameters are available for a certain function. Also when querying R using ??function_name it shows the deprecated function rather than the new. |
You are referring to OMA? It should not use deprecated functions, and should be updated. Can you list those problematic chapters and create an issue so that we can fix those? |
|
opened it in #519. |
|
Hi - can we fix & close this PR? |
|
Should be fixed now |
inst/pages/98_exercises.qmd
Outdated
| ``` | ||
|
|
||
|
|
||
| ======= |
There was a problem hiding this comment.
Also there is no reply for this (or modification as suggested)
|
Some final suggestions. |
|
@Insaynoah can you resolve all open points and then confirm if it is ready to merge |
inst/pages/98_exercises.qmd
Outdated
| show_warnings = FALSE) | ||
| ``` | ||
|
|
||
| 4. plot a heatmap using the correlations and mark significant correlations (p<0.05)with a cross. |
Sync # Conflicts: # inst/pages/98_exercises.qmd
Co-authored-by: Leo Lahti <leo.lahti@iki.fi> Co-authored-by: TuomasBorman <tvborm@utu.fi>
@AxelDgn and I updated the exercise page as suggested in #359.
The following has been updated